{ACR} Mask refresh token in test_acr_create_normal_check_health#33426
Open
isra-fel wants to merge 2 commits into
Open
{ACR} Mask refresh token in test_acr_create_normal_check_health#33426isra-fel wants to merge 2 commits into
isra-fel wants to merge 2 commits into
Conversation
Obscured sensitive refresh token in test recording.
️✔️AzureCLI-FullTest
|
|
Hi @isra-fel, |
️✔️AzureCLI-BreakingChangeTest
|
Obscured the refresh token in the test recording for security.
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
yanzhudd
changed the title
yanzhudd
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ACR scenario test recordings to obscure a sensitive ACR /oauth2/exchange refresh_token that was previously checked into the repo.
Changes:
- Masked the
refresh_tokenvalue returned by the ACR/oauth2/exchangeendpoint in two test recording YAML files. - Replaced the recorded token value with a placeholder string (
"******").
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_login_expose_token.yaml | Masks the /oauth2/exchange refresh_token in the recorded response body. |
| src/azure-cli/azure/cli/command_modules/acr/tests/latest/recordings/test_acr_create_normal_check_health.yaml | Masks the /oauth2/exchange refresh_token in the recorded response body. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
309
to
313
| uri: https://clireg000002.azurecr.io/oauth2/exchange | ||
| response: | ||
| body: | ||
| string: '{"refresh_token":"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IkxHSEY6Q0NLNDpDVVRaOlQzWUc6UFc2Mjo1UEFaOjJST086TjNZVTpOUUVaOkdXWDU6VDRZUjpVR0JXIn0.eyJqdGkiOiI2NzJjMjFiMS1iOTU2LTQ5MTQtOGNmYS04NjY0NDIyZDY5NWQiLCJzdWIiOiJjbGFya3BvcnRlckBtaWNyb3NvZnQuY29tIiwibmJmIjoxNzc2ODAzNTA2LCJleHAiOjE3NzY4MTUyMDYsImlhdCI6MTc3NjgwMzUwNiwiaXNzIjoiQXp1cmUgQ29udGFpbmVyIFJlZ2lzdHJ5IiwiYXVkIjoiY2xpcmVnczU2cHFhNzR1NWt4czIuYXp1cmVjci5pbyIsInZlcnNpb24iOiIxLjAiLCJyaWQiOiJiZGMzMmM0NzhkYjI0M2JlYjhkYmNjY2YzZWE3ZmNiZSIsImdyYW50X3R5cGUiOiJyZWZyZXNoX3Rva2VuIiwiYXBwaWQiOiIwNGIwNzc5NS04ZGRiLTQ2MWEtYmJlZS0wMmY5ZTFiZjdiNDYiLCJ0ZW5hbnQiOiI3MmY5ODhiZi04NmYxLTQxYWYtOTFhYi0yZDdjZDAxMWRiNDciLCJwZXJtaXNzaW9ucyI6eyJhY3Rpb25zIjpbInJlYWQiLCJ3cml0ZSIsImRlbGV0ZSIsIm1ldGFkYXRhL3JlYWQiLCJtZXRhZGF0YS93cml0ZSIsImRlbGV0ZWQvcmVhZCIsImRlbGV0ZWQvcmVzdG9yZS9hY3Rpb24iXX0sInJvbGVzIjpbXX0.Ym2bVIlurUAYN5mrdiFT3VqQfpfZQqajiLF9H0Jf9kOljAyiCEaBeNNUCied_fA7hhMlXdXUhhlbmQlBEbNLCiDcGFrbgUvsqm8cqUyOPWIRJYKryI3f0iw-l9ngm4yBZg1QLdNqYaR84MYcAO0hjIqCXAS1BVBhysXR75jhpAS1sIetpu9ugKY6rG-AgpgZbCmFYS1O4tgfooiXxNZ4NH0rOLN57vqTIZJghRwIPZ5HiE3TiCRB6ndKSqezDpgf1-3_hYzB8ovTz8w_3_aJDWWjY3x9t854uRZCsk1w3H-F6z1S-COTpuOgZL3NSw30d-LlH5Oy4iNKwnbuArzVLg"}' | ||
| string: '{"refresh_token":"******"}' | ||
| headers: |
Comment on lines
311
to
315
| uri: https://clitestrbac000002.azurecr.io/oauth2/exchange | ||
| response: | ||
| body: | ||
| string: '{"refresh_token":"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IkxHSEY6Q0NLNDpDVVRaOlQzWUc6UFc2Mjo1UEFaOjJST086TjNZVTpOUUVaOkdXWDU6VDRZUjpVR0JXIn0.eyJqdGkiOiIwOGFmMGJlMS0xMDY3LTRmMmUtOTAyNi02NDc5MGZmMTdmYjMiLCJzdWIiOiJjbGFya3BvcnRlckBtaWNyb3NvZnQuY29tIiwibmJmIjoxNzc1MDg0NzE1LCJleHAiOjE3NzUwOTY0MTUsImlhdCI6MTc3NTA4NDcxNSwiaXNzIjoiQXp1cmUgQ29udGFpbmVyIFJlZ2lzdHJ5IiwiYXVkIjoiY2xpdGVzdHJiYWMyaDJueC5henVyZWNyLmlvIiwidmVyc2lvbiI6IjEuMCIsInJpZCI6IjMwNmQzZDg2OTBmMjQwNWFiOGEyYjY0YzI4MjljYmNkIiwiZ3JhbnRfdHlwZSI6InJlZnJlc2hfdG9rZW4iLCJhcHBpZCI6IjA0YjA3Nzk1LThkZGItNDYxYS1iYmVlLTAyZjllMWJmN2I0NiIsInRlbmFudCI6IjcyZjk4OGJmLTg2ZjEtNDFhZi05MWFiLTJkN2NkMDExZGI0NyIsInBlcm1pc3Npb25zIjp7ImFjdGlvbnMiOlsicmVhZCIsIndyaXRlIiwiZGVsZXRlIiwibWV0YWRhdGEvcmVhZCIsIm1ldGFkYXRhL3dyaXRlIiwiZGVsZXRlZC9yZWFkIiwiZGVsZXRlZC9yZXN0b3JlL2FjdGlvbiJdfSwicm9sZXMiOltdfQ.RmvlTPlBgcLXCDE3fPv-z_Yy2gLbubKKHKiR6XOOe-Pmuhf2iKRLstNuMSERKNQGT3XYnSrsFz4M5Wuy1ytVADYF0_sns5_mO8cHAjNucDugeEGQximyXCFgaQnpNo6H1So2iywX32-kyzrADzB0SvBJ8sRSvJ7rPByoNKjrtHiDW6g56tAzbqONS5Ct1MTmKTYMcXSaMqJPDvDmTaG-Lzbj1W8ZrNo2OqUnzglAtFXOdEExZQfvvxoz_5Bh9vTjAxVIteVigCVCVlSAR3_o3d9t0x-9vCIlfKHC-FyE7YvpQRtlathdQLvWjc0SWWouT_tfyySw-vpgfzOuP2ghHw"}' | ||
| string: '{"refresh_token":"******"}' | ||
| headers: |
Comment on lines
311
to
315
| uri: https://clitestrbac000002.azurecr.io/oauth2/exchange | ||
| response: | ||
| body: | ||
| string: '{"refresh_token":"eyJhbGciOiJSUzI1NiIsInR5cCI6IkpXVCIsImtpZCI6IkxHSEY6Q0NLNDpDVVRaOlQzWUc6UFc2Mjo1UEFaOjJST086TjNZVTpOUUVaOkdXWDU6VDRZUjpVR0JXIn0.eyJqdGkiOiIwOGFmMGJlMS0xMDY3LTRmMmUtOTAyNi02NDc5MGZmMTdmYjMiLCJzdWIiOiJjbGFya3BvcnRlckBtaWNyb3NvZnQuY29tIiwibmJmIjoxNzc1MDg0NzE1LCJleHAiOjE3NzUwOTY0MTUsImlhdCI6MTc3NTA4NDcxNSwiaXNzIjoiQXp1cmUgQ29udGFpbmVyIFJlZ2lzdHJ5IiwiYXVkIjoiY2xpdGVzdHJiYWMyaDJueC5henVyZWNyLmlvIiwidmVyc2lvbiI6IjEuMCIsInJpZCI6IjMwNmQzZDg2OTBmMjQwNWFiOGEyYjY0YzI4MjljYmNkIiwiZ3JhbnRfdHlwZSI6InJlZnJlc2hfdG9rZW4iLCJhcHBpZCI6IjA0YjA3Nzk1LThkZGItNDYxYS1iYmVlLTAyZjllMWJmN2I0NiIsInRlbmFudCI6IjcyZjk4OGJmLTg2ZjEtNDFhZi05MWFiLTJkN2NkMDExZGI0NyIsInBlcm1pc3Npb25zIjp7ImFjdGlvbnMiOlsicmVhZCIsIndyaXRlIiwiZGVsZXRlIiwibWV0YWRhdGEvcmVhZCIsIm1ldGFkYXRhL3dyaXRlIiwiZGVsZXRlZC9yZWFkIiwiZGVsZXRlZC9yZXN0b3JlL2FjdGlvbiJdfSwicm9sZXMiOltdfQ.RmvlTPlBgcLXCDE3fPv-z_Yy2gLbubKKHKiR6XOOe-Pmuhf2iKRLstNuMSERKNQGT3XYnSrsFz4M5Wuy1ytVADYF0_sns5_mO8cHAjNucDugeEGQximyXCFgaQnpNo6H1So2iywX32-kyzrADzB0SvBJ8sRSvJ7rPByoNKjrtHiDW6g56tAzbqONS5Ct1MTmKTYMcXSaMqJPDvDmTaG-Lzbj1W8ZrNo2OqUnzglAtFXOdEExZQfvvxoz_5Bh9vTjAxVIteVigCVCVlSAR3_o3d9t0x-9vCIlfKHC-FyE7YvpQRtlathdQLvWjc0SWWouT_tfyySw-vpgfzOuP2ghHw"}' | ||
| string: '{"refresh_token":"******"}' | ||
| headers: |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obscured sensitive refresh token in test recording.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.