[MySQL] az mysql flexible-server backup create/restore/geo-restore/replica: Remove --storage-redundancy#33428
Open
honghr wants to merge 2 commits into
Open
[MySQL] az mysql flexible-server backup create/restore/geo-restore/replica: Remove --storage-redundancy#33428honghr wants to merge 2 commits into
az mysql flexible-server backup create/restore/geo-restore/replica: Remove --storage-redundancy#33428honghr wants to merge 2 commits into
Conversation
honghr
requested review from
Pan-Qi,
VeryEarly,
calvinhzy and
jsntcy
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @honghr, |
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
evelyn-ys,
wangzelin007,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
Bot
added
Storage
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR removes support for the --storage-redundancy option from Azure CLI MySQL flexible server commands and stops sending a storage_redundancy field in storage model payloads.
Changes:
- Remove
storage_redundancyparameters from command implementations andmodels.Storage(...)construction. - Remove CLI argument registration for
--storage-redundancyacross create/restore/geo-restore/replica create. - Remove breaking-change deprecation registrations for
--storage-redundancy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/mysql/custom.py | Drops storage_redundancy from command signatures and storage payload construction. |
| src/azure-cli/azure/cli/command_modules/mysql/_params.py | Removes --storage-redundancy argument type and registrations from command parameter wiring. |
| src/azure-cli/azure/cli/command_modules/mysql/_breaking_change.py | Removes the deprecation registrations for --storage-redundancy. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
772
to
777
| else: | ||
| auto_io_scaling = _determine_auto_io_scaling_by_faster_restore(faster_restore) | ||
|
|
||
| if not storage_redundancy: | ||
| storage_redundancy = source_server_object.storage.storage_redundancy | ||
|
|
||
| if not backup_retention: | ||
| backup_retention = source_server_object.backup.backup_retention_days | ||
| else: |
| storage = models.Storage(storage_size_gb=storage_gb, iops=iops, auto_grow=auto_grow, | ||
| auto_io_scaling=auto_io_scaling, | ||
| log_on_disk=accelerated_logs, storage_redundancy=storage_redundancy) | ||
| log_on_disk=accelerated_logs) |
Comment on lines
366
to
369
| c.argument('public_access', arg_type=public_access_create_arg_type) | ||
| c.argument('vnet', arg_type=vnet_arg_type) | ||
| c.argument('vnet_address_prefix', arg_type=vnet_address_prefix_arg_type) | ||
| c.argument('storage_redundancy', arg_type=storage_redundancy_arg_type, default="LocalRedundancy") | ||
| c.argument('subnet', arg_type=subnet_arg_type) |
| @@ -2,10 +2,3 @@ | |||
| # Copyright (c) Microsoft Corporation. All rights reserved. | |||
| # Licensed under the MIT License. See License.txt in the project root for license information. | |||
| # -------------------------------------------------------------------------------------------- | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az mysql flexible-server create --storage-redundancy
az mysql flexible-server restore --storage-redundancy
az mysql flexible-server geo-restore --storage-redundancy
az mysql flexible-server replica --storage-redundancy
Description
Remove storage redundancy for mysql server creation, restore and replica. Backend has been not supported this feature.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.