HTTP/2 PING keepalive handler for idle connection protection#49095
Draft
jeet1995 wants to merge 1 commit intoAzure:mainfrom
Draft
HTTP/2 PING keepalive handler for idle connection protection#49095jeet1995 wants to merge 1 commit intoAzure:mainfrom
jeet1995 wants to merge 1 commit intoAzure:mainfrom
Conversation
Extracts the HTTP/2 PING health probing feature from PR Azure#48420 (AzCosmos_HttpConnectionMaxLife) as a standalone changeset. Production code: - Http2PingHandler: sends PING frames on idle H2 parent channels - Configs: COSMOS.HTTP2_PING_HEALTH_ENABLED + PING_INTERVAL_IN_SECONDS - ReactorNettyClient: installs PingHandler via doOnConnected - IHttpClientInterceptor: test hook for DNS resolver + doOnConnected - HttpClientConfig/ConnectionPolicy/CosmosClientBuilder: interceptor plumbing Test code: - Http2PingKeepaliveTest: proves PINGs sent and ACKed on idle connections - Http2PingFrameCounterHandler: test utility for counting PING ACK frames - manual-http-network-fault TestNG suite + Maven profile Verified in Docker (--cap-add=NET_ADMIN): 5 PINGs sent, 10 ACKs received. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extracts the HTTP/2 PING keepalive feature from PR #48420 as a standalone changeset.
Sends periodic PING frames on idle H2 parent channels to prevent L7 middleboxes (NAT gateways, firewalls, load balancers) from silently reaping connections.
Changes
Production (azure-cosmos):
Test (azure-cosmos-tests):
Test Results (Docker, --cap-add=NET_ADMIN)
\
RESULT: pingsSent=5, pingAcksReceived=10
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
\\
Related
Split from #48420