Skip to content

Broaden update_versions.py regex to handle custom XML property tags #49262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeet1995 wants to merge 1 commit into from
+5 −1
Closed

Broaden update_versions.py regex to handle custom XML property tags #49262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/versioning/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@

# External dependency versions do not have to match semver format and the semver regular expressions
# will partially match and produce some hilarious results.
external_dependency_version_regex = r'(?<=<version>).+?(?=</version>)'
# Match version content inside any XML element, not just <version>.
# This handles custom property tags like <scala-jackson.version>2.18.6</scala-jackson.version>
# that carry {x-version-update} comments but are not wrapped in <version> elements.
# The lookahead (?=</[a-zA-Z]) ensures we don't match content before XML comments (<!-- -->).
external_dependency_version_regex = r'(?<=>)[^<]+(?=</[a-zA-Z])'
Comment on lines +30 to +34
Copy link
Copy Markdown
Member

@alzimmermsft alzimmermsft May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to restrict this slightly to either matching <version>...</version> exactly or a common pattern we use for <properties>...</properties> version definitions? Such as all version declarations in <properties>...</properties> suffix with .version.

The regex then can be something like (?<=<((?:[\w-.]+\.)?version)>).+?(?=<\/\1>), where we look for an XML tag that is either <version> itself or <something-custom.morestuff.version>. This also changes the logic to use the first capture group to match the closing tag so we don't need to double define the capture group.


# This is the original regular expression for semver. This differs from the
# previous one in that start of line and end of line anchors are left in place.
Expand Down