Skip to content

Tighten update_versions.py regex to match <version> and <*.version> tags #49267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeet1995 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

Tighten update_versions.py regex to match <version> and <*.version> tags #49267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion eng/versioning/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,10 @@

# External dependency versions do not have to match semver format and the semver regular expressions
# will partially match and produce some hilarious results.
external_dependency_version_regex = r'(?<=<version>).+?(?=</version>)'
# Match version content inside <version> or custom property tags ending with .version
# (e.g. <scala-jackson.version>). The lookahead restricts to closing tags that are
# either </version> or </something.version>, rejecting unrelated tags like </description>.
external_dependency_version_regex = r'(?<=>)[^<]+(?=</(?:[\w.\-]+\.)?version>)'

# This is the original regular expression for semver. This differs from the
# previous one in that start of line and end of line anchors are left in place.
Expand Down