Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16323 #49784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 4 commits into from
Jul 21, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 16323 #49784

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa14a4d
Make failures report errors.
tjprescott Jul 10, 2026
7f265a4
Code review feedback.
tjprescott Jul 21, 2026
9ec1c00
Apply suggestions from code review
tjprescott Jul 21, 2026
c4e6adf
Merge branch 'main' into sync-eng-common-apiviewFailureUpdate-16323
tjprescott Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/common/scripts/Create-APIReview.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,10 @@ function ProcessPackage($packageInfo)
{
if (!$apiStatus.IsApproved)
{
Write-Host "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)."
Write-Host "Build and release is not allowed for GA package without API review approval."
Write-Host "You will need to queue another build to proceed further after API review is approved"
Write-Host "You can check http://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval."
Write-Error "Package version $($version) is GA and automatic API Review is not yet approved for package $($packageInfo.ArtifactName)." -ErrorAction Continue
Write-Error "Build and release is not allowed for GA package without API review approval." -ErrorAction Continue
Write-Error "You will need to queue another build to proceed further after API review is approved" -ErrorAction Continue
Write-Error "You can check https://aka.ms/azsdk/engsys/apireview/faq for more details on API Approval." -ErrorAction Continue
}
return 1
}
Expand Down Expand Up @@ -437,7 +437,7 @@ foreach($pkg in $responses.keys)
{
if ($responses[$pkg] -eq 1)
{
Write-Host "API changes are not approved for $($pkg)"
Write-Error "API changes are not approved for $($pkg)" -ErrorAction Continue
$exitCode = 1
}
}
Expand Down
Loading