Migrate web-pubsub packages to #platform/* imports#38390
Draft
deyaaeldeen wants to merge 5 commits intomainfrom
Draft
Migrate web-pubsub packages to #platform/* imports#38390deyaaeldeen wants to merge 5 commits intomainfrom
deyaaeldeen wants to merge 5 commits intomainfrom
Conversation
- Updated warp.config.yml to extend base config - Created config/ directory with modular tsconfig files - Updated eslint.config.mjs with projectService: false - Updated vitest.browser.config.ts to use source-based browser testing - Updated scripts in package.json - Deleted old tsconfig files from package root Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add config/ directory with ESM, CJS, browser, react-native tsconfigs - Add imports field in package.json for #platform/* wildcard resolution - Create websocketClient-react-native.mts platform file - Update source imports to use #platform/websocket/websocketClient - Update warp.config.yml to extend base config - Add eslint.config.mjs with projectService: false for import resolution - Update vitest.browser.config.ts to use eng/vitestconfigs/browser.config.ts - Remove old tsconfig files (tsconfig.src.json, tsconfig.test.json, etc.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…tsconfig structure - Add config/ directory with ESM, CJS, browser, react-native, test, samples, snippets, and lint tsconfigs - Update tsconfig.json references to point to config/ directory - Update api-extractor.json with explicit tsconfigFilePath - Update test:node script to use --node-config flag - Remove old tsconfig files from package roots Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
These packages don't support browser/react-native: - web-pubsub-express: Express middleware (server-side only) - web-pubsub-client-protobuf: Only supports Node.js per README Changes: - Override warp targets to only build esm/commonjs - Remove react-native devDependency - Remove imports field (not needed without platform files) - Remove unused browser/react-native tsconfig files - Warp auto-cleaned exports to remove browser/react-native entries Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates all web-pubsub SDK packages to use the new
#platform/*wildcard import subpaths pattern, replacing the oldpolyfillSuffixapproach.Packages Migrated
@azure/web-pubsub@azure/web-pubsub-client#platform/*imports@azure/web-pubsub-client-protobuf@azure/web-pubsub-expressKey Changes
config/directory with tsconfig files extendingeng/tsconfigs/warp.config.ymlto extend base configimportsfield inpackage.jsonfor#platform/*resolutioneslint.config.mjswithprojectService: falsefor import resolutionvitest.browser.config.tsto useeng/vitestconfigs/browser.config.tstsc -b --noEmitto test scriptsTesting
All packages build and pass tests:
@azure/web-pubsub: 26 node tests@azure/web-pubsub-client: 90 node tests, 90 browser tests@azure/web-pubsub-client-protobuf: 26 node tests@azure/web-pubsub-express: 49 node tests