Migrate @azure-rest packages to config folder structure (Group 1/3)#38426
Draft
deyaaeldeen wants to merge 6 commits intomainfrom
Draft
Migrate @azure-rest packages to config folder structure (Group 1/3)#38426deyaaeldeen wants to merge 6 commits intomainfrom
deyaaeldeen wants to merge 6 commits intomainfrom
Conversation
deyaaeldeen
force-pushed
the
config-folders-group3
branch
3 times, most recently
from
3e277e9 to
d0e4e80
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
deyaaeldeen
force-pushed
the
config-folders-group3
branch
from
d0e4e80 to
b9d6fcc
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
AsyncDisposable doesn't exist in browser/react-native environments. Add platform-specific type stubs that export never for non-Node environments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix warp.config.yml to use array format with 'name:' keys (not object format) - Fix models.ts import order (import before use) - Fix utils.ts Symbol.asyncDispose for browser compatibility - Fix types.ts to use globalThis.AsyncDisposable Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
These packages are already properly migrated on main: - sdk/core/core-lro - sdk/core/core-sse - sdk/keyvault/keyvault-common - sdk/keyvault/keyvault-keys - sdk/keyvault/keyvault-secrets Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Client packages need tsconfig.samples.json at the root for build:samples script. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Properly migrate 20 @azure-rest packages to the config folder pattern used by communication/identity/keyvault libs.
Changes Per Package
config/folder with tsconfig files extendingeng/tsconfigs/tsconfig.jsonto reference./config/pathswarp.config.ymlwith explicit target tsconfig pathstsconfig.src.json,tsconfig.test.json, etc.Packages Migrated (20)
Part of config folder migration effort (Group 1 of 3).