Skip to content

[AutoPR azure-resourcemanager-fileshares]-generated-from-SDK Generation - Python-6239783#46602

Closed
ankushbindlish2 wants to merge 9 commits intoAzure:mainfrom
ankushbindlish2:fileshares-GA-apiversion-python
Closed

[AutoPR azure-resourcemanager-fileshares]-generated-from-SDK Generation - Python-6239783#46602
ankushbindlish2 wants to merge 9 commits intoAzure:mainfrom
ankushbindlish2:fileshares-GA-apiversion-python

Conversation

@ankushbindlish2
Copy link
Copy Markdown
Member

@ankushbindlish2 ankushbindlish2 commented Apr 29, 2026 •
edited by azure-sdk
Loading

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Release Plan Details

Copilot AI review requested due to automatic review settings April 29, 2026 06:38
Copilot AI reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new management-plane Python SDK package, azure-mgmt-fileshares (1.0.0b1), under the new sdk/fileshares/ service directory, along with CI wiring and the generated client implementation, docs stubs, samples, and test scaffolding.

Changes:

  • Add a new service directory pipeline definition at sdk/fileshares/ci.yml.
  • Add the new sdk/fileshares/azure-mgmt-fileshares package (generated sources, packaging files, metadata).
  • Add generated samples/tests scaffolding for the new client API surface.

Reviewed changes

Copilot reviewed 78 out of 80 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
sdk/fileshares/ci.yml New service directory CI pipeline configuration for fileshares.
sdk/fileshares/azure-mgmt-fileshares/tsp-location.yaml TypeSpec/spec location pin for generation source.
sdk/fileshares/azure-mgmt-fileshares/toc_tree.rst Sphinx doc TOC stub for the package.
sdk/fileshares/azure-mgmt-fileshares/pyproject.toml Package build metadata and dependencies.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_private_link_resources_operations_async.py Generated async test scaffolding for private link resources operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_private_link_resources_operations.py Generated sync test scaffolding for private link resources operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_private_endpoint_connections_operations_async.py Generated async test scaffolding for private endpoint connections operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_private_endpoint_connections_operations.py Generated sync test scaffolding for private endpoint connections operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_operations_async.py Generated async test scaffolding for operations list.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_operations.py Generated sync test scaffolding for operations list.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_informational_operations_operations_async.py Generated async test scaffolding for informational operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_informational_operations_operations.py Generated sync test scaffolding for informational operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_file_shares_operations_async.py Generated async test scaffolding for file shares operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_file_shares_operations.py Generated sync test scaffolding for file shares operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_file_share_snapshots_operations_async.py Generated async test scaffolding for snapshot operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/test_file_shares_file_share_snapshots_operations.py Generated sync test scaffolding for snapshot operations.
sdk/fileshares/azure-mgmt-fileshares/generated_tests/conftest.py Test-proxy sanitizers and environment loading for recordings.
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_link_resources_list_by_file_share.py Generated sample for listing private link resources.
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_link_resources_get.py Generated sample for getting a private link resource.
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_list_by_file_share.py Generated sample for listing private endpoint connections.
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_get.py Generated sample for getting a private endpoint connection.
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_delete.py Generated sample for deleting a private endpoint connection (LRO).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/private_endpoint_connections_create.py Generated sample for creating a private endpoint connection (LRO).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/operations_list_minimum_set_gen.py Generated sample for operations list (minimum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/operations_list_maximum_set_gen.py Generated sample for operations list (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_update_maximum_set_gen.py Generated sample for updating a file share (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_subscription_minimum_set_gen.py Generated sample for listing file shares by subscription (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_subscription_maximum_set_gen.py Generated sample for listing file shares by subscription (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_parent_minimum_set_gen.py Generated sample for listing file shares by parent (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_list_by_parent_maximum_set_gen.py Generated sample for listing file shares by parent (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_get_maximum_set_gen.py Generated sample for getting a file share (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_delete_maximum_set_gen.py Generated sample for deleting a file share (LRO).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_create_or_update_maximum_set_gen.py Generated sample for create/update a file share (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_check_name_availability_minimum_set_gen.py Generated sample for name availability check (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_shares_check_name_availability_maximum_set_gen.py Generated sample for name availability check (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_update_maximum_set_gen.py Generated sample for updating a snapshot (LRO).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_list_minimum_set_gen.py Generated sample for listing snapshots (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_list_maximum_set_gen.py Generated sample for listing snapshots (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_get_maximum_set_gen.py Generated sample for getting a snapshot (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_delete_maximum_set_gen.py Generated sample for deleting a snapshot (LRO).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_snapshot_create_or_update_maximum_set_gen.py Generated sample for create/update a snapshot (maximum set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_usage_data_minimum_set_gen.py Generated sample for usage data (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_usage_data_maximum_set_gen.py Generated sample for usage data (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_provisioning_recommendation_minimum_set_gen.py Generated sample for provisioning recommendation (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_provisioning_recommendation_maximum_set_gen.py Generated sample for provisioning recommendation (max set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_limits_minimum_set_gen.py Generated sample for limits (min set).
sdk/fileshares/azure-mgmt-fileshares/generated_samples/file_share_get_limits_maximum_set_gen.py Generated sample for limits (max set).
sdk/fileshares/azure-mgmt-fileshares/dev_requirements.txt Dev/test dependency pinning for the package directory.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/py.typed PEP 561 typing marker for the package.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/operations/_patch.py Customization hook stub for operations namespace.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/operations/init.py Operations namespace exports and patch hook invocation.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/_patch.py Customization hook stub for models namespace.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/_enums.py Generated enum types for the service.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/models/init.py Models namespace exports and patch hook invocation.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/operations/_patch.py Async operations customization hook stub.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/operations/init.py Async operations exports and patch hook invocation.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_patch.py Async package-level customization hook stub.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_configuration.py Async client configuration (policies, auth).
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/_client.py Async management client implementation.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/aio/init.py Async package exports/version patch hook.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_version.py Package version constant (dynamic version source).
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_validation.py API version validation helper decorator.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_utils/model_base.py Generated model base/serialization infrastructure.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_utils/init.py Utils package marker.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_patch.py Sync package-level customization hook stub.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_configuration.py Sync client configuration (policies, auth).
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/_client.py Sync management client implementation.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/fileshares/init.py Sync package exports/version patch hook.
sdk/fileshares/azure-mgmt-fileshares/azure/mgmt/init.py Namespace package marker for azure.mgmt.
sdk/fileshares/azure-mgmt-fileshares/azure/init.py Namespace package marker for azure.
sdk/fileshares/azure-mgmt-fileshares/apiview-properties.json APIView cross-language mapping metadata.
sdk/fileshares/azure-mgmt-fileshares/_metadata.json Generated API version metadata.
sdk/fileshares/azure-mgmt-fileshares/README.md Package README (currently template-based).
sdk/fileshares/azure-mgmt-fileshares/MANIFEST.in Source distribution include rules.
sdk/fileshares/azure-mgmt-fileshares/LICENSE MIT license text.
sdk/fileshares/azure-mgmt-fileshares/CHANGELOG.md Initial release changelog entry for 1.0.0b1.

Comment thread sdk/fileshares/azure-mgmt-fileshares/tsp-location.yaml Outdated
Comment thread sdk/fileshares/azure-mgmt-fileshares/pyproject.toml
Comment thread sdk/fileshares/azure-mgmt-fileshares/toc_tree.rst Outdated
Comment thread sdk/fileshares/azure-mgmt-fileshares/README.md Outdated
Comment thread sdk/fileshares/azure-mgmt-fileshares/README.md
Comment thread sdk/fileshares/azure-mgmt-fileshares/README.md Outdated
@ankushbindlish2 ankushbindlish2 changed the title [DoNotMerge] Add azure-mgmt-fileshares SDK package [GA Version 2026-06-01 (1.0.0b1) [DoNotMerge] Add azure-mgmt-fileshares SDK package [GA Version 2026-06-01 (1.0.0b1) [Python] Apr 29, 2026
ankushbindlish2 and others added 6 commits April 30, 2026 10:46
@ankushbindlish2
Add tests for azure-mgmt-fileshares with assets.json recordings
e6f4198 
- Add hand-written tests/ suite (CRUD, listing, snapshots, edge cases, negatives, private endpoint, complex scenarios, informational) using AzureMgmtRecordedTestCase.

- Rewrite generated_tests/ to use realistic FileShare payloads via shared _helpers.py and proxy 'variables' for name persistence across record/playback.

- Add assets.json pointing at azure-sdk-assets tag python/fileshares/azure-mgmt-fileshares_d5b0dfcc03 (67 recordings: 31 hand-written + 36 generated).

- Live + playback both pass against canary ARM (eastus2euap) using GA api-version 2026-06-01.
@ankushbindlish2
Merge branch 'main' into fileshares-GA-apiversion-python
9478a7d
@ankushbindlish2
Fix pytest module name collision: rename tests/_helpers.py to _fs_tes…
3f4aa66 
…t_helpers.py
@ankushbindlish2
Merge branch 'main' into fileshares-GA-apiversion-python
bd4330f
@ankushbindlish2
Mark unrecorded fileshares tests as live_test_only
a955028 
test_file_share_crud and test_operations_list have no proxy recording committed to the assets repo, so they fail in CI playback. Mark them live_test_only until recordings are captured and pushed.
@ankushbindlish2
Update tsp-location.yaml to use official azure/azure-rest-api-specs repo
ad37854
@ankushbindlish2 ankushbindlish2 changed the title [DoNotMerge] Add azure-mgmt-fileshares SDK package [GA Version 2026-06-01 (1.0.0b1) [Python] Add azure-mgmt-fileshares SDK package [GA Version 2026-06-01 (1.0.0b1) [Python] May 1, 2026
@ankushbindlish2 ankushbindlish2 enabled auto-merge (squash) May 2, 2026 14:42
@VincentLiu777
Copy link
Copy Markdown

VincentLiu777 commented May 5, 2026

Release Plan: https://aka.ms/sdk-release-planner?release-plan-id=1122d42a-f834-f111-88b4-000d3a5a7991

@msyyc msyyc mentioned this pull request May 6, 2026
Merged
@ankushbindlish2 ankushbindlish2 changed the title Add azure-mgmt-fileshares SDK package [GA Version 2026-06-01 (1.0.0b1) [Python] [AutoPR azure-resourcemanager-fileshares]-generated-from-SDK Generation - Python-6239783 May 6, 2026
@msyyc
Copy link
Copy Markdown
Member

msyyc commented May 6, 2026

move this PR to #46749.
NOTE: mainly for the test files which was added by ankushbindlish2

CC @ankushbindlish2

@msyyc msyyc closed this May 6, 2026
auto-merge was automatically disabled May 6, 2026 08:45

Pull request was closed

@msyyc msyyc mentioned this pull request May 6, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@ChenxiJiang333 ChenxiJiang333 Awaiting requested review from ChenxiJiang333 ChenxiJiang333 is a code owner

Assignees

No one assigned

Labels

fileshares

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankushbindlish2 @VincentLiu777 @msyyc