Skip to content

Fix path traversal vulnerability in artifact tool zip extraction #46713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushhgarg-work wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix path traversal vulnerability in artifact tool zip extraction #46713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions sdk/ml/azure-ai-ml/azure/ai/ml/_utils/_artifact_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,23 @@ def _redirect_artifacts_tool_path(self, organization: Optional[str]):
url, headers=header
)
if response.status_code == 200:
artifacts_tool_path = tempfile.mkdtemp() # nosec B306
artifacts_tool_path = Path(tempfile.mkdtemp()) # nosec B306
artifacts_tool_uri = response.json()["uri"]
response = requests_pipeline.get(artifacts_tool_uri) # pylint: disable=too-many-function-args
resolved_dest = artifacts_tool_path.resolve()
with zipfile.ZipFile(BytesIO(response.content)) as zip_file:
zip_file.extractall(artifacts_tool_path)
os.environ["AZURE_DEVOPS_EXT_ARTIFACTTOOL_OVERRIDE_PATH"] = str(artifacts_tool_path.resolve())
self._artifacts_tool_path = artifacts_tool_path
for member in zip_file.namelist():
member_path = (resolved_dest / member).resolve()
if member_path != resolved_dest and not str(member_path).startswith(
str(resolved_dest) + os.sep
):
raise RuntimeError(
f"Artifact tool archive contains a path traversal entry and cannot be "
f"extracted safely: {member}"
)
zip_file.extractall(resolved_dest)
os.environ["AZURE_DEVOPS_EXT_ARTIFACTTOOL_OVERRIDE_PATH"] = str(resolved_dest)
self._artifacts_tool_path = resolved_dest
else:
_logger.warning("Download artifact tool failed: %s", response.text)

Expand Down
Loading