Auto-assign Copilot to next- issues generated from weekly run, and add fix-pyright skill#46726
Open
JennyPng wants to merge 19 commits intoAzure:mainfrom
Open
Auto-assign Copilot to next- issues generated from weekly run, and add fix-pyright skill#46726JennyPng wants to merge 19 commits intoAzure:mainfrom
JennyPng wants to merge 19 commits intoAzure:mainfrom
Conversation
JennyPng
requested review from
a team,
benbp,
l0lawrence and
mccoyp
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the eng/tools/azure-sdk-tools vnext issue automation to optionally auto-assign the Copilot coding agent for eligible next-* issues (with duplicate PR detection and version-bump retriggering), and adds a new fix-pyright skill to align with existing fix-* skills.
Changes:
- Add Copilot auto-fix helpers to vnext issue creation/update flow (labels, instruction block upsert, duplicate PR detection, GraphQL assignment, and optional force-reassign on version change).
- Add unit tests covering eligibility, duplicate PR detection, instruction generation, label reconciliation, and assignment flows.
- Add
fix-pyrightskill documentation and update engineering docs (including removing the outdated Ruff row).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/tools/azure-sdk-tools/tests/test_vnext_auto_fix.py | Adds tests for Copilot auto-fix helpers and integration behavior. |
| eng/tools/azure-sdk-tools/gh_tools/vnext_issue_creator.py | Implements Copilot auto-fix logic (instructions/labels/assignment) and updates some type signatures and mgmt labeling heuristic. |
| doc/eng_sys_checks.md | Documents the Copilot auto-fix behavior for weekly next-* checks. |
| doc/analyze_check_versions.md | Removes the Ruff row from the checker version table. |
| .github/skills/fix-pyright/SKILL.md | Introduces a new skill guide for fixing pyright issues, consistent with other fix-* skills. |
Comment on lines
+156
to
+158
| end_idx = body.find(COPILOT_AUTOFIX_END) | ||
| if start_idx != -1 and end_idx != -1: | ||
| return body[:start_idx].rstrip() + instructions |
Member
Author
There was a problem hiding this comment.
i dont think we ever expect human authored content in the issue?
Comment on lines
+107
to
+116
| try: | ||
| open_prs = repo.get_pulls(state="open", sort="created", direction="desc") | ||
| for pr in open_prs: | ||
| body = pr.body or "" | ||
| title = pr.title or "" | ||
| search_text = f"{title} {body}".lower() | ||
|
|
||
| # 1. PR explicitly references the issue number | ||
| issue_ref = f"#{issue_number}" | ||
| has_issue_ref = issue_ref in title or issue_ref in body |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
scbedd
reviewed
May 5, 2026
| **Command:** | ||
| ```powershell | ||
| cd <package-path> | ||
| azpysdk --isolate pyright . |
Member
There was a problem hiding this comment.
This assumes eng/tools/azure-sdk-tools is installed. We probably point to it in a skill that references this? if not, we need to repeat ourselves I think.
scbedd
reviewed
May 5, 2026
|
|
||
| **Command:** | ||
| ```powershell | ||
| cd <package-path> |
Member
There was a problem hiding this comment.
Suggested change
| cd <package-path> | |
| cd <package-path> | |
| # install dev_requirements.txt |
scbedd
reviewed
May 5, 2026
| **If virtual environment is missing:** | ||
| Ask: "Do you have an existing virtual environment path, or should I create 'env'?" | ||
|
|
||
| ### Step 1: CRITICAL - Activate Virtual Environment FIRST |
Member
There was a problem hiding this comment.
analyzeare run on python 3.10- We should mention this when deciding to re-use or active a venv.
scbedd
reviewed
May 5, 2026
| **IMMEDIATELY activate the virtual environment before ANY other command:** | ||
|
|
||
| ```powershell | ||
| # Activate the provided virtual environment (e.g., env, venv) |
Member
There was a problem hiding this comment.
Real talk. agents are quite good at activating venvs. As long as you tell them activate a venv before all commands it should take care of it crossplat.
Member
There was a problem hiding this comment.
Just make certain it knows what version of python to prep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core:
misc.
tests: