Propagate directory upload errors without progress - #48242
Conversation
|
Thank you for your contribution @JensWehner! We will review the pull request and get back to you soon. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
Ensures directory upload worker failures propagate when progress display is disabled.
Changes:
- Observes all upload futures regardless of progress settings.
- Adds a regression test for
show_progress=False.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
_asset_utils.py |
Propagates background upload exceptions without progress. |
test_asset_utils.py |
Tests error propagation in that path. |
|
@JensWehner - Can you please update change log as well? |
|
The CI is fixed in this PR: #47787 Once this is merged, pls rebase. |
372b79d to
9df430e
Compare
[Pilot] PR Pipeline Failure AnalysisA CI pipeline failed on this pull request. Here is an automated analysis of what went wrong and how to get the build green. What failedThree test failures were detected in the
The two Recommended next steps
Raw pipeline analysis (azsdk ci analyze)
|
Directory upload futures are only observed when progress is enabled. Always observe them so worker failures propagate with
show_progress=False.Fixes #48269