App Config - Pylint Changes

[mrm9084]

Description

Fixes for:

• azure-appconfiguration needs linting updates for pylint version 4.0.6 #48262
• azure-appconfiguration-provider needs linting updates for pylint version 4.0.6 #46388

Have a request out for a test ignore for no-cross-package-private-import (Testing private methods)

Have requests out for sample ignores for reimported, wrong-import-position, wrong-import-order, and ungrouped-imports (These are due to how sample files are used in docs such as Readme.md and we need to list the imports for each usage.)

All SDK Contribution checklist:

• The pull request does not introduce [breaking changes]
• CHANGELOG is updated for new features, bug fixes or other significant changes.
• I have read the contribution guidelines.

General Guidelines and Best Practices

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).
9 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

[Copilot]

Pull request overview

Updates App Configuration docstrings to satisfy Pylint 4.0.6 checks without changing runtime behavior.

Changes:

• Adds constructor parameter documentation to models and policies.
• Removes invalid callback parameter documentation.
• Expands public model descriptions.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
_sync_token_async.py	Simplifies async policy documentation.
_sync_token.py	Simplifies sync policy documentation.
_models.py	Expands model and paging documentation.
_azure_appconfiguration_requests.py	Documents credential policy parameters.
_audience_error_handling_policy.py	Documents the audience flag.
_request_tracing_context.py	Documents load-balancing configuration.

Comments suppressed due to low confidence (2)

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py:152

• This attribute documentation claims All requirement semantics, but FeatureFlagConfigurationSetting neither exposes nor preserves a requirement type; its serialized value contains only client_filters. Please avoid advertising unsupported behavior here.

    """Filters that run on the client to determine whether the feature is enabled. By default
        (requirement type "Any"), the feature is considered enabled if at least one filter evaluates
        to true. With requirement type "All", every filter must evaluate to true."""

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py:200

• The constructor cannot choose All: there is no requirement_type argument and the generated conditions contain only client_filters. This wording makes an unsupported mode appear available to callers, so document only the emitted default semantics.

        :keyword filters: Filters that run on the client to determine whether the feature is enabled.
            By default (requirement type "Any"), the feature is considered enabled if at least one filter
            evaluates to true. With requirement type "All", every filter must evaluate to true.
        :paramtype filters: list[dict[str, Any]] or None

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (3)

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py:136

• The FeatureFlagConfigurationSetting model does not expose or serialize a requirement type: its constructor writes only conditions.client_filters (lines 216–218), and _from_generated drops any requirement_type from a fetched value (lines 258–291). Documenting All here therefore implies that callers can select semantics this API cannot represent. Please keep this description neutral unless requirement-type support is added.

    :keyword filters: Filters that run on the client to determine whether the feature is enabled.
        By default (requirement type "Any"), the feature is considered enabled if at least one filter
        evaluates to true. With requirement type "All", every filter must evaluate to true.
    :paramtype filters: list[dict[str, Any]] or None

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py:152

• This attribute cannot carry the documented requirement type; it contains only the client-filter list, while serialization always emits client_filters without requirement_type. Mentioning Any/All here overstates the model's supported behavior.

    """Filters that run on the client to determine whether the feature is enabled. By default
        (requirement type "Any"), the feature is considered enabled if at least one filter evaluates
        to true. With requirement type "All", every filter must evaluate to true."""

sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_models.py:200

• The constructor accepts only the filter list and always serializes it without a requirement_type, so callers cannot request the documented All behavior. Please avoid documenting requirement-type modes on this parameter unless the model is extended to preserve and serialize them.

        :keyword filters: Filters that run on the client to determine whether the feature is enabled.
            By default (requirement type "Any"), the feature is considered enabled if at least one filter
            evaluates to true. With requirement type "All", every filter must evaluate to true.
        :paramtype filters: list[dict[str, Any]] or None