-
Notifications
You must be signed in to change notification settings - Fork 332
Update config validation logic for entities #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronburtle
wants to merge
32
commits into
main
Choose a base branch
from
dev/aaronburtle/warn-zero-entities-validate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
eab2698
Fix #3267: Warn when dab validate finds zero entities in the config
aaronburtle e2849f8
Add test for #3267: Verify warning when zero entities defined
aaronburtle 0459fb3
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 447b0da
Fix zero-entities check: use .Entities.Count, .Autoentities.Count, an…
aaronburtle ff044ed
Consolidate TryGetConfig to a single call in IsConfigValid
aaronburtle c62ed09
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 346f079
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 94aa01d
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
anushakolan 57c15ed
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle d402495
address comments
aaronburtle ef7df09
Merge branch 'dev/aaronburtle/warn-zero-entities-validate' of github.…
aaronburtle 4f93225
new validation logic
aaronburtle 535b209
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle d99a098
cleanup
aaronburtle 26be2f9
Merge branch 'dev/aaronburtle/warn-zero-entities-validate' of github.…
aaronburtle f33b77b
use child configs instead of new metadata class
aaronburtle 06c131e
better tests
aaronburtle 8fee9c0
format
aaronburtle 88f7eae
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 8e76209
fix tests
aaronburtle d8c7569
Merge remote-tracking branch 'origin/main' into dev/aaronburtle/warn-…
aaronburtle 5c93d5e
...
aaronburtle eb0d335
fix tests to match new logic, correct isValidateOnly logic
aaronburtle 09bcd9e
fix test conflict
aaronburtle c5d5288
format
aaronburtle 9b4edcb
format
aaronburtle c091e61
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 1817254
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 57fc4fd
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle 8b25cae
add test gap coverage
aaronburtle a279947
address comments
aaronburtle 7ecad1c
Merge branch 'main' into dev/aaronburtle/warn-zero-entities-validate
aaronburtle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.