Add identity logging to ARM token exchange through IMDS#111
Open
Copilot wants to merge 3 commits into
Open
Conversation
Co-authored-by: matucker-msft <77026928+matucker-msft@users.noreply.github.com>
Co-authored-by: matucker-msft <77026928+matucker-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Log what identity you are trying to login with when doing the token exchange
Add identity logging to ARM token exchange through IMDS
Jun 6, 2025
matucker-msft
approved these changes
Jun 7, 2025
Member
There was a problem hiding this comment.
I really have nothing to say. copilot did this well and plumbed the logger through to all the places and at least gave us the exact log line we wanted while debugging an issue today. This passes my sniff test, but I need 2 more approvals cause this is a copilot PR :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logging to show what identity is being used when performing token exchange through IMDS (Instance Metadata Service), making it easier to debug authentication issues.
Changes Made
Enhanced Token Exchange Logging
The
ARMTokenForBindingfunction now logs the specific identity being used for authentication:Example Log Output
Technical Implementation
armTokenFetcherfunction type to include alogr.LoggerparameterARMTokenForBindingfunction signature to accept and use the loggerCreatePullCredentialfunction to pass logger context through the call chainThis provides much-needed visibility into which identity is being used during token exchange operations, helping operators troubleshoot authentication issues more effectively.
Fixes #110.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.