fix(e2e): break up e2e and refresh tokens between steps#128
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Breaks up the E2E workflow into more granular steps and refreshes Azure OIDC logins between them to avoid token expiry during long runs.
Changes:
- Add a wait in the e2e test to ensure the default ServiceAccount exists before creating a pod that relies on it.
- Make test/Makefile cleanup more defensive when extracting resource group/deployment names.
- Update the GitHub Actions E2E workflow to add concurrency control and refresh
azure/loginbetween stages (infra, build/import, test, cleanup).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/e2e_test.go | Wait for default ServiceAccount to exist before creating a pod that depends on it. |
| test/Makefile | Improves robustness of cleanup and uses order-only prerequisites for _output. |
| .github/workflows/e2e.yaml | Adds concurrency + login refresh steps to reduce failures from expired OIDC assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stevekuznetsov
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.