Improve assertion usage patterns#1032
Merged
Avery-Dunn merged 5 commits intoJun 4, 2026
Merged
Conversation
Update test dependencies and build plugins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the changes/branch in this other PR of test improvements: #1031
This PR is meant to handle a minor but widespread code quality issue in our unit tests: JUnit's
assertEqualsmethod expects to be given parameters like(expectedValue, actualValue), but about a quarter of the time we passed in(actualValue, expectedValue)This doesn't affect the actual test behavior in any meaningful way, but can easily create confusion when looking at logs in failing pipelines. This PR should correct the order in every usage of
assertEqualsUnrelated to that, this PR also adjusts a couple of integration test classes in order to use existing helpers for some common assertion patterns (mainly validating the existence/absence of tokens in a result).
These changes are more-or-less just stylistic and code quality issues, and will not affect the source code or current test coverage.