[minor] [engg]: Bump IdentityCore to include DI foundation (#1810/#1838/#1809)#3000
Merged
Conversation
#1809) Advances MSAL/IdentityCore submodule from ce438cc1e to 00ab949b4 to pull in the next batch of MSIDDIContainer dependency-injection seams (the container itself, #1807, was already included in the prior pin). Common Core PRs pulled in: - #1810 Route MSIDWorkPlaceJoinUtil through MSIDDIContainer (WPJ seam) - #1838 Harden MSIDDIContainer (thread-safety + protocol conformance check) - #1809 Route MSIDThrottlingService through MSIDDIContainer (throttling seam) Plus a handful of unrelated bugfix/feature commits that landed on CC dev between the two pins (visionOS build fix #1840, pop/recCnf fix #1832, Mobile Onboarding navigation #1817, etc.). Related to: PBI 3571651, Task 3612431 (https://dev.azure.com/IdentityDivision/Engineering/_workitems/edit/3612431). The downstream broker bump that consumes this MSAL change is tracked in Task 3612430. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the MSAL/IdentityCore git submodule pointer to a newer Common Core commit to pick up additional MSIDDIContainer dependency-injection seams and related hardening, and records the update in the top-level changelog.
Changes:
- Advance
MSAL/IdentityCoresubmodule pin to include DI container routing/hardening work from Common Core. - Add a
CHANGELOG.mdentry describing the IdentityCore/Common Core update.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CHANGELOG.md | Adds a release-note bullet describing the IdentityCore/Common Core DI-related submodule bump. |
| MSAL/IdentityCore | Updates the submodule pointer to a newer Common Core commit containing DI container changes. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rokhrest
approved these changes
May 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Friendly ping 👋 @swasti29 @galwarsamy @AzureAD/msal-objc-ciam — this is a routine IdentityCore submodule bump to pull in the DI foundation. Already approved by @rokhrest and Copilot threads are resolved. Whenever you have a few minutes, would love a look so we can land this and unblock the downstream broker bump. Thanks! |
rokhrest
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine Common Core submodule bump. Advances
MSAL/IdentityCorefromce438cc1e→00ab949b4to pull in the next batch ofMSIDDIContainerdependency-injection seams (the container itself, CC #1807, was already included in the prior pin).Common Core PRs pulled in
MSIDWorkPlaceJoinUtilthroughMSIDDIContainer(WPJ seam)MSIDDIContainer(thread-safety + protocol conformance check)MSIDThrottlingServicethroughMSIDDIContainer(throttling seam)Plus a handful of unrelated commits that landed on CC
devbetween the two pins (visionOS build fix #1840, pop/recCnf fix #1832, Mobile Onboarding navigation #1817, etc.) — seegit diff --submodule=login the diff for the full list.ADO
Downstream
The broker pointer bump that consumes this MSAL change is tracked in Task 3612430 and will land in a separate PR.
Validation
Local build/test skipped — relying on PR CI. No source changes; only the submodule pointer and a CHANGELOG entry are modified.
— Authored by Forge/Coder