Fix Quality Gate CI: dead detekt action + non-observable locale

[Azyrn]

The Quality Gate workflow has failed on every push for weeks. There were two independent causes, plus a config that had never been exercised.

1. Detekt job — the action was deleted

detekt/detekt-action@v2 no longer exists on GitHub (hard 404), so the job died in ~2s during Set up job. It never ran a single check. Replaced with the official detekt CLI jar, pinned to the 1.23.8 already in the version catalog.

Because detekt had never actually run, turning it on surfaced 1310 issues against a maxIssues: 0 gate. Worked down as follows:

	count	action
ktlint formatting	~700	auto-corrected (separate commit)
config bugs, not defects	~450	fixed the rules
genuine debt	258	baselined

detekt.yml was also invalid for 1.23.8 (renamed ComplexMethod, deprecated ForbiddenComment.values/customMessage, excludedFunctions as a comma-string) — fatal under warningsAsErrors: true.

Two rules were misconfigured rather than strict:

• FunctionNaming flagged 100 @Composable functions — the config used excludeClassPattern, which doesn't do that; ignoreAnnotated does.
• MagicNumber fired on ColorSchemes (HCT tone tables) and ImageOps (tensor normalization means/stds), where the literals are the domain. Naming 218 of them would obscure the math.

The gate is verified real, not green-by-default: injecting a printStackTrace + magic number into a scratch file fails at exit 2; removing it passes at exit 0.

2. Android Lint job — a real bug

HistoryScreen.kt:286 read Locale.getDefault() inside a composable (NonObservableLocale), so history timestamps would not re-format when the user changed system locale. Now uses LocalLocale.current.platformLocale, with the SimpleDateFormat hoisted into a remember.

Verified locally

• ./gradlew lint → BUILD SUCCESSFUL (was: 1 error)
• ./gradlew compileDebugKotlin → BUILD SUCCESSFUL (confirms the 87-file format pass is safe)
• detekt → exit 0 baselined, exit 2 on new issues

Reviewing

Read it commit-by-commit — the two real fixes are isolated from the formatting churn, which is style: apply detekt --auto-correct and is behaviour-free.

Follow-up

The 258 baselined findings are real debt — notably 20 SwallowedException, the kind that hides bugs. Worth burning down separately.

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
scanly	Ready	Preview, Comment	Jul 13, 2026 5:22am

[github-advanced-security]

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

• The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
• Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
• You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.