chore(lookup): migrate Open Food Facts to API v3#13
Merged
Conversation
v2 is deprecated; v3 is the version the docs recommend for new integrations.
All three OFF-family projects (Food, Beauty, Pet Food) serve it.
v3 reports the outcome as a string ("success"/"failure") where v2 used an
integer 1, and a missing product still comes back as HTTP 200 — so the
`status: Int` DTOs would have thrown a SerializationException on every
lookup. Switch the three response DTOs to a string status and gate on it.
Field names and the `fields` query param are unchanged in v3 (verified live
against all three hosts), so the product/nutriments mappings stay as they are.
Also fix the User-Agent to the AppName/Version (contact) format OFF asks for,
and share it from one place instead of two hardcoded copies.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2 is deprecated; v3 is the version the docs recommend for new integrations. All three OFF-family projects (Food, Beauty, Pet Food) serve it.
v3 reports the outcome as a string ("success"/"failure") where v2 used an integer 1, and a missing product still comes back as HTTP 200 — so the
status: IntDTOs would have thrown a SerializationException on every lookup. Switch the three response DTOs to a string status and gate on it.Field names and the
fieldsquery param are unchanged in v3 (verified live against all three hosts), so the product/nutriments mappings stay as they are.Also fix the User-Agent to the AppName/Version (contact) format OFF asks for, and share it from one place instead of two hardcoded copies.