Skip to content

Fill template and save from file upload field#26

Closed
lsgs wants to merge 2 commits into
BCCHR-IT:masterfrom
lsgs:mcri-dev
Closed

Fill template and save from file upload field#26
lsgs wants to merge 2 commits into
BCCHR-IT:masterfrom
lsgs:mcri-dev

Conversation

@lsgs
Copy link
Copy Markdown

@lsgs lsgs commented Apr 8, 2021

File upload field dialog enables selection of template to fill and save to field as an alternative to selecting an existing file.
Module project settings for alternative paper size and orientation for templates.

lsgs added 2 commits April 9, 2021 09:33
Can fill template and save from file upload field.
Options for alternative paper size and orientation
@remifrazierucsf
Copy link
Copy Markdown

@BCCHR-IT @lsgs let us know if there's anything we can do to support this PR at this time.

@274188A
Copy link
Copy Markdown
Contributor

274188A commented Apr 7, 2022

@remifrazierucsf - I went ahead and tried out manually copying over @lsgs (Luke's) files form his PR - no problems so far. I suggest it might be a good idea to do a transfer of 'Ownership' for this repo given the current owners seem indisposed for long periods of time.

@remifrazierucsf
Copy link
Copy Markdown

@BCCHR-IT is there any chance that this feature request will be (or has been) merged in for the next release? We can provide some engineering support for this if that would help.

(Moved this comment over here from the closed #22 where I accidentally posted it originally.)

@BCCHR-IT
Copy link
Copy Markdown
Owner

@remifrazierucsf it wasn't pulled in to the PHP8 compatibility update, no. The original PR has some conflicts with the current changes that I haven't gone through yet, as I now have to focus on the changes needed to use RC's new data export rights scheme.

If you have the capacity to resolve the conflicts between that original PR and the current main, I can test them and merge if they're successful.

@remifrazierucsf
Copy link
Copy Markdown

@BCCHR-IT we will take a look. Thanks!

@remifrazierucsf
Copy link
Copy Markdown

@BCCHR-IT are you okay with us still looking at this? We're almost ready to finally.

@BCCHR-IT
Copy link
Copy Markdown
Owner

@BCCHR-IT are you okay with us still looking at this? We're almost ready to finally.

Hi @remifrazierucsf , I have just pushed the v4.0.0 update to the consortium for review and hopeful release. If you have the bandwidth to look at the proposed changes vs the new v4 codebase, that would be appreciated!

@lsgs lsgs closed this Nov 3, 2023
@lsgs lsgs deleted the mcri-dev branch November 3, 2023 06:13
@remifrazierucsf
Copy link
Copy Markdown

@lsgs was this item actually implemented in 4.0.0?

@lsgs
Copy link
Copy Markdown
Author

lsgs commented Nov 4, 2023

No @remifrazierucsf, it wasn't. The PR was pretty messy though. I have just done a couple of new ones based on v4.0.0, one for each of the two additional features:

  1. Project settings for template paper size and orientation (pull/55)
  2. Integration with data entry form file upload fields (pull/56)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants