Add N-API compliance tests by matthargett · Pull Request #116 · BabylonJS/JsRuntimeHost

JavaScriptCore wrapper previously passed nullptr to JSObjectCallAsFunction when the receiver was undefined, so the VM forcibly substituted the global object even in strict mode. The new implementat…

matthargett

committed

Add the node-lite test suite Vlad added into hermes-windows. The JSC bug fix in strict mode was actually found by the suite! The failing behavior was exercised by Tests/NodeApi/test/js-native-api/3…

matthargett

committed

Android tests now pass. StdoutLogger was holding on to destroyed mutex handles during instrumentation, causing crashes, and now route console output through the new NodeLiteRuntime::Callbacks. On A…

matthargett

committed

Run the macOS NodeApiTests under sanitizers, which found another bug -- a use-after-free. Will check sanitizers under Android next

matthargett

committed

Fix build errors. This deduplicates struct definitions that were inlined into our copy of the JSI code.

matthargett

committed

always build the napi tests

matthargett

committed

try and get address sanitizer and thread sanitizer to run on Android, since they found bugs on macOS + JSC

matthargett

committed

Add N-API version/conformance roadmap (folds in engine-compat baseline)

matthargett

committed

Restore NodeApi tests build on current macOS toolchain

matthargett

committed

Restore Android NodeApi test build (compiles/links/installs/runs on emulator)

matthargett

committed

Fix Android NodeApi harness JNI crash; wire up SetNodeApiTestEnvironment

matthargett

committed

Android: make the NodeApi conformance tests actually execute on-device

matthargett

committed

Android: enter the V8 context in jsr_open_napi_env_scope (fix napi_create_object segfault)

matthargett

committed

Android/in-process node_lite: let ExitOnException propagate the fatal error

matthargett

committed

Android/in-process: make node_lite teardown destructors exception-safe

matthargett

committed

Android/in-process: guard the fatal handler against throwing while unwinding

matthargett

committed

Android/in-process: drop noexcept from throwing error-exit functions (fixes terminate)

matthargett

committed

Android: skip in-process js-native-api addon tests pending shared-lib napi

matthargett

committed

docs(roadmap): document Android in-process addon-load constraint + shared-lib napi follow-up

matthargett

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add N-API compliance tests#116

Add N-API compliance tests#116
matthargett wants to merge 33 commits into
BabylonJS:mainfrom
rebeckerspecialties:napi-tests

Commits on Jun 4, 2026

JavaScriptCore wrapper previously passed nullptr to JSObjectCallAsFunction when the receiver was undefined, so the VM forcibly substituted the global object even in strict mode. The new implementat…

Add the node-lite test suite Vlad added into hermes-windows. The JSC bug fix in strict mode was actually found by the suite! The failing behavior was exercised by Tests/NodeApi/test/js-native-api/3…

Android tests now pass. StdoutLogger was holding on to destroyed mutex handles during instrumentation, causing crashes, and now route console output through the new NodeLiteRuntime::Callbacks. On A…

Run the macOS NodeApiTests under sanitizers, which found another bug -- a use-after-free. Will check sanitizers under Android next

Fix build errors. This deduplicates struct definitions that were inlined into our copy of the JSI code.

always build the napi tests

try and get address sanitizer and thread sanitizer to run on Android, since they found bugs on macOS + JSC

Add N-API version/conformance roadmap (folds in engine-compat baseline)

Restore NodeApi tests build on current macOS toolchain

Restore Android NodeApi test build (compiles/links/installs/runs on emulator)

Fix Android NodeApi harness JNI crash; wire up SetNodeApiTestEnvironment

Android: make the NodeApi conformance tests actually execute on-device

Android: enter the V8 context in jsr_open_napi_env_scope (fix napi_create_object segfault)

Android/in-process node_lite: let ExitOnException propagate the fatal error

Android/in-process: make node_lite teardown destructors exception-safe

Android/in-process: guard the fatal handler against throwing while unwinding

Android/in-process: drop noexcept from throwing error-exit functions (fixes terminate)

Android: skip in-process js-native-api addon tests pending shared-lib napi

docs(roadmap): document Android in-process addon-load constraint + shared-lib napi follow-up

Commits on Jun 5, 2026

Android: statically link conformance addons into the test binary (run in-process)

Android tests: pump native stdout/stderr to logcat

docs(roadmap): Android v5 js-native-api now green via static linking (supersedes skip)

Android: drop the now-dead dynamic-.node build machinery (superseded by static linking)

Android: remove vestigial V8Platform scaffolding from the env holder

docs(roadmap): record node-api-cts FetchContent evaluation (task 6) — track, don't adopt yet

Android: dlopen conformance addons as dynamic .node backed by a shared libnapi.so

docs(roadmap): Android uses dynamic .node + shared libnapi.so (aligns with node-api-cts)

Android tests: use AndroidExtensions StdoutLogger for stdout->logcat

docs(roadmap): stdout->logcat is via AndroidExtensions StdoutLogger, not a hand-rolled pump

Sync napi shared-lib change with PR #183 (gate behind JSR_NAPI_SHARED option)

Tests: enable the v5-clean reference double-free conformance test

docs(roadmap): reference-test staging + GC-safety review (re hermes-windows#321)

Node-API: address #116 review (JSC call dispatch, status type, Windows error reporting)