Skip to content

Fix Windows/UWP CI build (MSVC C4875 + JSI include path) #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthargett wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix Windows/UWP CI build (MSVC C4875 + JSI include path) #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5eacedd
build: suppress MSVC C4875 from vendored GSL to unblock the Windows b…
matthargett Jun 5, 2026
12fbd51
Core/Node-API-JSI: add the shared napi include path (fixes pre-existi…
matthargett Jun 5, 2026
b05a38a
Address review: scope C4875 to C++ (COMPILE_LANGUAGE:CXX); single PUB…
matthargett Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,17 @@ set_property(GLOBAL PROPERTY USE_FOLDERS ON)
set(CMAKE_CXX_STANDARD 20)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

# A newer MSVC (windows-latest) emits C4875 ("a non-string literal argument to [[gsl::suppress]] is
# deprecated") from the vendored GSL headers, which several targets compile with warnings-as-error.
# Suppress this dependency-side deprecation so the Windows build isn't broken by toolchain drift. Must
# be set before arcana.cpp / Core / Polyfills are added below so they inherit it. Scoped to C++ (the
# warning only fires for GSL's C++ [[gsl::suppress]] attribute); kept directory-wide because GSL is
# pulled in transitively by many targets (arcana, AppRuntime, the polyfills) and no first-party code
# uses a non-string [[gsl::suppress]], so this doesn't mask our own warnings.
if(MSVC)
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:/wd4875>)
endif()
Comment thread
matthargett marked this conversation as resolved.

# --------------------------------------------------
# Options
# --------------------------------------------------
Expand Down
8 changes: 7 additions & 1 deletion Core/Node-API-JSI/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ if(NOT TARGET jsi)
endif()

target_include_directories(napi
PUBLIC "include")
PUBLIC
"include"
# napi.h pulls in the shared <napi/js_native_api_types.h>, which lives in
# Core/Node-API/Include/Shared. That sibling isn't built when the engine is JSI
# (Core/CMakeLists.txt selects Node-API-JSI instead of Node-API), so reference the shared
# headers directly here -- otherwise the JSI napi fails to compile with C1083.
"${CMAKE_CURRENT_SOURCE_DIR}/../Node-API/Include/Shared")

target_link_libraries(napi
PUBLIC jsi)
Expand Down