fix(tui): keep palette highlight on the selected row when scrolled - #35
Merged
Conversation
The ^K popup renders a scrolling window of maxPalRows entries but compared the window-relative index against the absolute selection, so the highlight vanished past row 8 and drifted onto the wrong row while scrolled. windowEntries now returns the window offset and the highlight compares absolute indices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowEntriesnow returns the window start offset; the highlight comparesstart+i == m.pal.sel.Test plan
TestPaletteSelectionTracksScroll: walks selection past the 8-row window and asserts exactly one highlighted row trackingpal.sel, then walks back to top. Failed before the fix (got 0highlighted rows), passes after.make fmt/make vet/make lint(0 issues) /make test(-race, all packages green)