Skip to content

docs: fix broken Notion CRM example link in Integrations page#6018

Merged
beastoin merged 2 commits intoBasedHardware:mainfrom
syou6162:fix/update_notion_crm_link
Mar 26, 2026
Merged

docs: fix broken Notion CRM example link in Integrations page#6018
beastoin merged 2 commits intoBasedHardware:mainfrom
syou6162:fix/update_notion_crm_link

Conversation

@syou6162
Copy link
Copy Markdown
Collaborator

@syou6162 syou6162 commented Mar 25, 2026

Summary

Fix broken "Notion CRM Example" link in the Integrations documentation page.

Background

The link at docs/doc/developer/apps/Integrations.mdx points to plugins/example/main.py, which no longer exists.

Commit fff6516 ("Move plugins from plugins/example/ to plugins/") flattened the plugin directory, moving all files from plugins/example/ up one level. The documentation link was not updated in that change, resulting in a 404.

The previous target (plugins/example/main.py, now plugins/main.py) was only a FastAPI router aggregation file — it never contained Notion CRM logic itself. The actual Notion CRM implementation lives in plugins/oauth/conversation_created.py, which handles the /notion-crm webhook endpoint, OAuth setup, and Notion row creation. This is the file the documentation intended to reference as a "complete implementation" example.

Changes

  • docs/doc/developer/apps/Integrations.mdx: Updated the "Notion CRM Example" link from plugins/example/main.py (404) to plugins/oauth/conversation_created.py (the actual implementation)

References

The link pointed to `plugins/example/main.py` which no longer exists.
Commit fff6516 moved all files from `plugins/example/` up to `plugins/`,
but the documentation was not updated, resulting in a 404.

Update the link to `plugins/oauth/conversation_created.py`, which contains
the actual Notion CRM implementation (webhook handler, OAuth setup, and
Notion row creation).
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Mar 25, 2026

Greptile Summary

This PR fixes a single broken documentation link: the "Notion CRM Example" in docs/doc/developer/apps/Integrations.mdx previously pointed to plugins/example/main.py, which no longer exists after the directory was flattened in a prior commit. The link is corrected to plugins/oauth/conversation_created.py, which is the actual file containing the Notion CRM webhook handler, OAuth setup, and Notion row creation logic.

  • The old target (plugins/example/main.py) was a FastAPI router aggregation file that was moved/removed; the link was a 404.
  • The new target (plugins/oauth/conversation_created.py) contains the /notion-crm endpoint, OAuth callback, database validation, and create_notion_row — exactly the "complete implementation" the documentation intends to showcase.
  • No logic changes; documentation-only fix.

Confidence Score: 5/5

  • This PR is safe to merge immediately — it's a targeted, documentation-only link fix with no logic changes.
  • The change is a single-line URL correction in an MDX doc file. The new target (plugins/oauth/conversation_created.py) exists in the repository and contains exactly the Notion CRM implementation described in the documentation. There are no code changes, no risk of regression, and the fix is factually correct.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/doc/developer/apps/Integrations.mdx Single-line fix updating the broken "Notion CRM Example" link from the non-existent plugins/example/main.py to the correct plugins/oauth/conversation_created.py, which contains the full Notion CRM implementation.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["Docs: Integrations.mdx\n'Notion CRM Example' link"] -->|"Before (404)"| B["plugins/example/main.py\n(deleted — router aggregation file)"]
    A -->|"After (✓ correct)"| C["plugins/oauth/conversation_created.py\n(Notion CRM implementation)"]
    C --> D["/setup-notion-crm — OAuth setup page"]
    C --> E["/auth/notion/callback — OAuth callback"]
    C --> F["/notion-crm — webhook handler"]
    C --> G["create_notion_row() — Notion API call"]
Loading

Reviews (1): Last reviewed commit: "docs: fix broken Notion CRM example link..." | Re-trigger Greptile

@beastoin beastoin merged commit 41307d0 into BasedHardware:main Mar 26, 2026
2 checks passed
@beastoin
Copy link
Copy Markdown
Collaborator

lgtm @syou6162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants