New release#88
Merged
Merged
Conversation
The floating jitpack snapshot v1.21-SNAPSHOT resolves to an ephemeral git-described build whose jar/POM get evicted, breaking CI even on unchanged commits. Switch to the equivalent stable Maven Central coordinates (org.mockbukkit.mockbukkit:mockbukkit-v1.21:4.110.0). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace HashMap.values().forEach() + remove() (which throws ConcurrentModificationException) with entrySet().removeIf(), the standard safe pattern for removing map entries during iteration. Also fix typos in the warning message: unknow→unknown, skiped→skipped. Add UpgradesDataManagerTest covering single orphan removal, valid-tier preservation, and multiple simultaneous orphans (the exact scenario reported with Boxed_example_range2_t1 and Boxed_example_diamond_t1).
Surefire hardcoded its own <argLine> (the --add-opens block), which
overwrote the argLine property that jacoco:prepare-agent sets to inject
the -javaagent flag. The agent never attached, no coverage was recorded,
and the empty jacoco.xml meant SonarCloud reported zero coverage.
Prepend @{argLine} (Maven late-replacement) so the JaCoCo agent flag is
combined with the --add-opens flags instead of clobbered. Also bump
JaCoCo 0.8.10 -> 0.8.13 to instrument newer JDK bytecode cleanly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.