Fix bug where GENERATE_PREFIXES registers the generated prefix but doesn't assign it to the namespace info#268
Merged
Conversation
…doesn't assign it to the namespace info The Fallback `parser/mod.rs::determine_prefixes` inserts the generated prefix into `self.schemas.known_prefixes` but does **not** write it back to `info.prefix`.
Contributor
Author
|
Hi, Thanks for your effort. You can find example code for this bug here. The README.md contains more details. This branch has the fix applied. Thanks for all your work you put into this project. |
Bergmann89
requested changes
Apr 27, 2026
Owner
Bergmann89
left a comment
Bergmann89
left a comment
There was a problem hiding this comment.
Hey @g-pichler,
thanks for your contribution. Looks good to me, just one small request: Instead of patching the expected outcome for the namespaces_qualified tests, could you please remove the GENERATE_PREFIXES flag from the test config? Then the test itself stays as it is and actually tests what it is intended to test. Here is a diff file to apply the changes I suggest: patch.txt
…test stay as-is. Also revert the changes to reference test files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fallback
parser/mod.rs::determine_prefixesinserts the generated prefix intoself.schemas.known_prefixesbut does not write it back toinfo.prefix.