Flattened struct helper functions#273
Open
Exotik850 wants to merge 9 commits into
Open
Conversation
Bergmann89
requested changes
May 27, 2026
Owner
Bergmann89
left a comment
There was a problem hiding this comment.
Looks good to me, nice work 👍
Some smaller things that need to be cleaned up, then this can be merged 🙃
Bergmann89
requested changes
May 28, 2026
Owner
Bergmann89
left a comment
There was a problem hiding this comment.
One last thing you forgot to revert 🙃
| /// List of keywords that needs to be replaced by something else. | ||
| /// This list needs to be sorted, because we use it in [`core::slice::binary_search_by`] | ||
| const KEYWORDS: &[(&str, &str)] = &[ | ||
| pub(crate) const KEYWORDS: &[(&str, &str)] = &[ |
Owner
There was a problem hiding this comment.
Since we now use the already prepared field_ident we don't need to export this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add flattened content helpers render step
This PR introduces the
FlattenedContentHelpersRenderStepwhich generates ergonomic helper accessor methods for flattened struct content patterns (e.g.,pub struct Foo { pub content: Vec<FooContent>, ... }withpub enum FooContent { ... }). The step creates methods likefn bar(&self) -> Option<&String>and mutable variants thereof for each enum variant, improving usability of generated code.Changes include:
src/pipeline/renderer/steps/flattened.rsThe feature is enabled via the renderer configuration and follows the existing pattern for optional render steps
e.g.