VerifAI Dynamic Sampling Compatibility#417
Conversation
dfremont
left a comment
There was a problem hiding this comment.
Looks fine overall, although I'm not sure what prompted the introduction of extractOutput -- maybe we can talk offline.
Co-authored-by: Daniel Fremont <dfremont@ucsc.edu>
| param timeBound = 250 | ||
|
|
||
| This value can also be set directly in VerifAI via the `maxSteps` parameter to the | ||
| `ScenicSampler`. |
There was a problem hiding this comment.
I think this reference will work if you add VerifAI to Intersphinx (see intersphinx_mapping in docs/conf.py).
There was a problem hiding this comment.
I'm just going to make this not be a link for the moment and we can improve it later.
dfremont
left a comment
There was a problem hiding this comment.
Looking good -- just a last few minor suggestions.
dfremont
left a comment
There was a problem hiding this comment.
Let's merge this as-is and we can come back to the last two minor comments later.
…fy/Scenic into VerifAIDynamicSampling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 89.90% 89.56% -0.34%
==========================================
Files 54 48 -6
Lines 13536 13283 -253
==========================================
- Hits 12169 11897 -272
- Misses 1367 1386 +19
🚀 New features to boost your workflow:
|
|
Thanks for the fixes, Eric! This is looking good -- we can revisit the coverage issue once the new version of VerifAI is out. |
Description
Adds compatibility with VerifAI dynamic sampling.
Issue Link
N/A
Checklist
pytestand/or other meansAdditional Notes
Merge with BerkeleyLearnVerify/VerifAI#58