Dockerfile: Changes to make Yarn work reliably#86
Open
awilfox wants to merge 1 commit into
Open
Conversation
* Move Yarn-managed packages to a specific directory, the same way we did in BerkeleyLibrary/UCBEARS#17. This makes it easier to handle. * Add Yarn binstubs to the available PATH. * Copy the lock file into the app directory, which is required for the cssbundling task to determine we are using Yarn. Otherwise we will have this error: cssbundling-rails: No suitable tool found for installing JavaScript dependencies * Switch to headless JRE to lower attack surface and use less resources. Ref: AP-779
anarchivist
approved these changes
Jul 13, 2026
anarchivist
left a comment
anarchivist
left a comment
Member
There was a problem hiding this comment.
generally r+; one minor question.
| # Use Yarn via Corepack to avoids using reops and GPG keys | ||
| RUN corepack enable \ | ||
| && corepack prepare yarn@stable --activate \ | ||
| && corepack prepare yarn@1.22.22 --activate \ |
Member
There was a problem hiding this comment.
is this effectively downgrading yarn from our past images?
Member
Author
There was a problem hiding this comment.
It installed a stable yarn that was never used, because the package specified 1.22.22. This just ensures it downloads that version the first time, so it doesn't waste the time of fetching a useless one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Yarn-managed packages to a specific directory, the same way we did in Added NODE_PATH to Dockerfile and configure yarn build in prod target UCBEARS#17. This makes it easier to handle.
Add Yarn binstubs to the available PATH.
Copy the lock file into the app directory, which is required for the cssbundling task to determine we are using Yarn. Otherwise we will have this error:
cssbundling-rails: No suitable tool found for installing JavaScript dependencies
Switch to headless JRE to lower attack surface and use less resources.
Ref: AP-779