Remove duplicate upload size predicate#1092
Conversation
Remove the unused ceiling-only helper so callers cannot bypass a lowered client upload limit. The retained predicate continues to fall back to the hard ceiling when no public override is configured.
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Summary
exceedsUploadSizeCeilingexport.exceedsClientUploadSizeis the single browser-side size predicate.Why
The effective client predicate already falls back to the hard ceiling when no public limit is configured and respects a lower operator limit when present. Keeping a second ceiling-only predicate creates a future path that could bypass the lowered limit.
RAG impact: no retrieval behaviour change — upload-limit helper cleanup only.
Verification
npm run verify:pr-local -- --files src/lib/upload-limits.ts— passed, including lint, typecheck, full unit suite, production build, and offline RAG fixtures.npm run test:focused -- --files src/lib/upload-limits.ts— 110 files, 1,196 tests passed.npm run typecheck— passed.npx prettier --check src/lib/upload-limits.ts— passed.git diff --check— passed.npm ci— passed; 0 vulnerabilities.Risk and rollout
origin/main, and the retained effective-limit predicate is unchanged.Clinical Governance Preflight
Clinical KB Database(sjrfecxgysukkwxsowpy)Notes
Confirmed the ported file is byte-identical to the archived dirty-worktree checkpoint.
Policy evidence refreshed after completing the required clinical-governance checklist.