Skip to content

Remove duplicate upload size predicate#1092

Merged
BigSimmo merged 1 commit into
mainfrom
codex/upload-limit-followup
Jul 23, 2026
Merged

Remove duplicate upload size predicate#1092
BigSimmo merged 1 commit into
mainfrom
codex/upload-limit-followup

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove the unused exceedsUploadSizeCeiling export.
  • Document why exceedsClientUploadSize is the single browser-side size predicate.

Why

The effective client predicate already falls back to the hard ceiling when no public limit is configured and respects a lower operator limit when present. Keeping a second ceiling-only predicate creates a future path that could bypass the lowered limit.

RAG impact: no retrieval behaviour change — upload-limit helper cleanup only.

Verification

  • npm run verify:pr-local -- --files src/lib/upload-limits.ts — passed, including lint, typecheck, full unit suite, production build, and offline RAG fixtures.
  • npm run test:focused -- --files src/lib/upload-limits.ts — 110 files, 1,196 tests passed.
  • npm run typecheck — passed.
  • npx prettier --check src/lib/upload-limits.ts — passed.
  • git diff --check — passed.
  • npm ci — passed; 0 vulnerabilities.
  • UI verification not run: the change removes an unused export and changes comments only; no UI or browser behaviour changed.
  • Provider verification not run: no Supabase, OpenAI, Railway, database, or live RAG behaviour changed.

Risk and rollout

  • Risk: low; the removed export has no caller on current origin/main, and the retained effective-limit predicate is unchanged.
  • Rollback: revert the single commit.
  • Provider or production effects: none; normal application deployment follows protected-main policy.

Clinical Governance Preflight

  • Source-backed claims still require linked source verification before clinical use
  • No patient-identifiable document workflow was introduced or expanded without explicit governance approval
  • Supabase target remains Clinical KB Database (sjrfecxgysukkwxsowpy)
  • Service-role keys and private document access remain server-only
  • Demo/synthetic content remains clearly separated from real clinical sources
  • Source metadata, review status, and outdated/unknown-source behavior remain conservative
  • Deployment classification/TGA SaMD impact was checked when clinical decision-support behavior changed

Notes

  • Confirmed the ported file is byte-identical to the archived dirty-worktree checkpoint.

  • Policy evidence refreshed after completing the required clinical-governance checklist.

Remove the unused ceiling-only helper so callers cannot bypass a lowered client upload limit. The retained predicate continues to fall back to the hard ceiling when no public override is configured.
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@BigSimmo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d8851a3d-31a3-4c0b-8309-9bfa269d7fed

📥 Commits

Reviewing files that changed from the base of the PR and between 5f6568d and cb34bb0.

📒 Files selected for processing (1)
  • src/lib/upload-limits.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/upload-limit-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 23, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo merged commit 5df8c96 into main Jul 23, 2026
19 of 23 checks passed
@BigSimmo
BigSimmo deleted the codex/upload-limit-followup branch July 23, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant