You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have added my own SVGs and tried rendering them but faced a problem that said "not a valid glyph", so I decided to test all glyphs already on the directory and found that most of them show up with the same error.
I think my SVG will work when we solve a problem related to the glyph's directory as it sounds like the library couldn't see my added SVGs files.
The problem with your glyph is that it is not a valid Parametric SBOL Visual glyph. This is because some of the details in the header are missing. If you look at one of the example glyphs (e.g., CDS.svg) from the glyphs folder you'll see there are extra entries at the top. Specifically,
In fact, I did.
I have two versions of my SVGs added to the repo, one on the Omar_work directory and the other in the glyph directory. I did that because I thought that all glyphs should be in the same directory in order for the load_glyphs_from_path function to see it.
In the glyph directory version, I have added glyphtype and parametric defaults but don't know what to do with terms so I tried to give the same value of CDS but unfortunately didn't work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added my own SVGs and tried rendering them but faced a problem that said "not a valid glyph", so I decided to test all glyphs already on the directory and found that most of them show up with the same error.
I think my SVG will work when we solve a problem related to the glyph's directory as it sounds like the library couldn't see my added SVGs files.
I have attached screenshots of the problem