Skip to content

sdk: round-5 CLI follow-ups — close last two producer↔recognizer drift guards (#0434) #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevormil merged 1 commit into from
May 15, 2026
Merged

sdk: round-5 CLI follow-ups — close last two producer↔recognizer drift guards (#0434) #245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/bitbadgesjs-sdk/src/core/builders/builders.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,11 @@ import { buildBid } from './bid.js';
import { buildPmSellIntent } from './pm-sell-intent.js';
import { buildPmBuyIntent } from './pm-buy-intent.js';
import { resolveCoin, parseDuration, toBaseUnits, sanitizeCosmosPathName, resolveExpiration } from './shared.js';
import { buildPredictionMarketBuyIntent, buildPredictionMarketSellIntent } from '../prediction-markets.js';
import { buildPredictionMarketBuyIntent, buildPredictionMarketSellIntent, isPredictionMarketValid, validatePredictionMarketCollection } from '../prediction-markets.js';
import { buildIntentApproval } from '../intents.js';
import { UintRangeArray } from '../uintRanges.js';
import { isQuestApproval, doesCollectionFollowQuestProtocol } from '../quests.js';
import { normalizeForReview } from '../review-normalize.js';
import { buildOrderbookBidApproval, buildOrderbookListingApproval } from '../bids.js';

// ── Helpers ──────────────────────────────────────────────────────────────────
Expand Down Expand Up @@ -589,6 +591,13 @@ describe('prediction-market builder', () => {
buildPredictionMarket({ verifier: 'bb1verifier', ...META })
);
});
test('producer↔recognizer drift guard — built collection satisfies isPredictionMarketValid (#0434)', () => {
const built = normalizeForReview(buildPredictionMarket({ verifier: 'bb1verifier', ...META }));
const res = validatePredictionMarketCollection(built);
expect(res.valid).toBe(true);
expect(res.errors).toEqual([]);
expect(isPredictionMarketValid(built)).toBe(true);
});
test('seven distinct pm-<role>-<hash> approval ids, stable across calls', () => {
const ids = r.collectionApprovals.map((a: any) => a.approvalId);
expect(ids.length).toBe(7);
Expand Down Expand Up @@ -712,6 +721,13 @@ describe('quests builder', () => {
const p = { reward: 10, denom: 'BADGE', maxClaims: 100, ...META };
expect(buildQuests(p)).toEqual(buildQuests(p));
});
test('producer↔recognizer drift guard — built quest is recognized by isQuestApproval (#0434)', () => {
const built = normalizeForReview(buildQuests({ reward: 10, denom: 'BADGE', maxClaims: 100, ...META }));
const questApproval = built.collectionApprovals.find((a: any) => a.approvalId === 'quests-approval');
expect(questApproval).toBeTruthy();
expect(isQuestApproval(questApproval)).toBe(true);
expect(doesCollectionFollowQuestProtocol(built as any)).toBe(true);
});
test('passes verification with zero violations', () => {
expectCleanVerification(msg);
});
Expand Down