liveDelay not calculated yet icon - #175
Open
jchristman75 wants to merge 4 commits into
Open
Conversation
jchristman75
force-pushed
the
bp-livedelay-icon
branch
from
August 8, 2026 12:28
f11e217 to
dd24deb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an onroad steering-lag calibration indicator to both the TICI and MICI HUDs. While
liveDelay.statusis not yetestimated, a small icon appears near the wheel button (TICI) / top-right corner (MICI). It renders white when the car is too slow for lagd to collect samples and green oncevEgo >= MIN_VEGO(15 m/s), so the driver can tell at a glance whether estimation is actually running. The icon disappears entirely once the estimate lands.Why
Steering-lag calibration is invisible today — there is no way to know whether it is progressing, stalled, or already done, which makes "my steering feels off after a reset" reports hard to diagnose. Ported the concept from the sp-dev-c3 tree, minus its two progress bars: the bars added clutter without changing what the driver would do, and the green/white state already answers the only actionable question ("is it collecting right now?").
Also this calculation is changing soon, so this indication might be more valuable.
How
LiveDelayIndicatoris a small shared widget inselfdrive/ui/bp/lib/, drawn by both HUD renderers so the TICI and MICI paths cannot drift apart. It readsliveDelayandcarStatestraight offui_state.sm— no new subscriptions,liveDelayis already in the SP sub list.widthargument (140 TICI, 44 MICI); height derives from the icon's aspect ratio.liveDelay.pngis committed as a plain git blob, not LFS, with an exclusion line in.gitattributesmatching the existingspinner_bluepilot.pngprecedent. The fork's pre-push hook deliberately skips LFS uploads (BluePilot consumes upstream LFS only), so an LFS-tracked asset added here resolves to a pointer that 404s on-device during smudge.Changes
selfdrive/ui/bp/lib/live_delay_indicator.py: NewLiveDelayIndicatorwidget — icon plus backdrop, hidden onceliveDelay.status == 'estimated', green aboveMIN_VEGO.selfdrive/ui/bp/onroad/hud_renderer_bp.py: Renders the indicator left of the wheel button, vertically centered on it.selfdrive/ui/bp/mici/onroad/hud_renderer_bp.py: Renders the indicator in the top-right corner..gitattributes: ExcludesliveDelay.pngfrom the LFS filter.selfdrive/assets/icons/liveDelay.png: New 387x270 icon asset.