Mici: show steering delay in compact lateral tuning modal - #180
Open
alexwhittemore wants to merge 2 commits into
Open
Mici: show steering delay in compact lateral tuning modal#180alexwhittemore wants to merge 2 commits into
alexwhittemore wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
Author
|
Hmmm. I see a couple of problems with this as written. For one, AutoCorrect on the comma four codename. Whoops. For two, it doesn’t seem to work. It displays a value, and that value isn’t hardcoded, but that value never changes over the course of a drive even when I’m editing the steering delay parameter. Must investigate further. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
alexwhittemore
changed the title
Author
|
I made some additional edits switching the source of truth for the value but I’m still not confident yet. The value shown still remains static for the duration of the drive even when I change the value in sunnylink. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The BP lateral tuning UI only shows the (live) steering delay parameter value on the tici/large screen. It’s very valuable for dialing in lateral performance on platforms so this change brings it to the Comma4 in a legible way.
Verification
Tested on dev machine/simulator, and on an Onroad Comma4