Quality Gate#6
Open
abdul-qadir92 wants to merge 31 commits into
Open
Conversation
:wq Removed listeners and js executors duplicates :wq
TC mapping
# Conflicts: # browserstack.yml
TRA Quality Gates
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Removed conditional check for sdk branch in workflow.
Comment on lines
+8
to
+24
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout sdk branch | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: sdk | ||
|
|
||
| - name: Set up JDK 11 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: '11' | ||
| cache: maven | ||
|
|
||
| - name: Run Accessibility tests | ||
| run: mvn test -P scenario-onprem -B |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 days ago
Add an explicit permissions block to the workflow so GITHUB_TOKEN is least-privileged by default.
Best fix here (without changing behavior) is to set workflow-level permissions to:
contents: read
This is sufficient for actions/checkout and does not grant unnecessary write scopes.
Edit .github/workflows/browserstack-accessibility.yml near the top-level keys (after on: and before jobs: is a clear placement).
Suggested changeset
1
.github/workflows/browserstack-accessibility.yml
| @@ -3,6 +3,9 @@ | ||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.