Extending schematron validation in e2e tests#568
Open
robertandremitchell wants to merge 7 commits into
Open
Conversation
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #568 +/- ##
==========================================
+ Coverage 90.85% 90.89% +0.03%
==========================================
Files 50 50
Lines 2691 2702 +11
==========================================
+ Hits 2445 2456 +11
Misses 246 246 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ed-eicr-to-e2e-test-harness
…ed-eicr-to-e2e-test-harness
…ed-eicr-to-e2e-test-harness
…ed-eicr-to-e2e-test-harness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances e2e tests to meet acceptance criteria from ticket:
The bulk of the changed files are about bring validation logic into the augmentation-lambda. Is this something we want to do? I fell down this rabbit hole with the e2e tests because one of them was invalid. Based on the ticket, it sounds like APHL wants Mirth to do this? In which case, maybe we don't need/want this code in the augmentation-lambda as well?
The alternative is just to drop this sample7 data from the e2e and replace it with another test where we expect to go e2e, or write a separate e2e pathway for it where we expect the data to get kicked back.
Related Issues
Closes #434
Additional Notes
[Add any additional context or notes that reviewers should know about.]
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: