Skip to content

Extending schematron validation in e2e tests#568

Open
robertandremitchell wants to merge 7 commits into
mainfrom
rob/434-add-schematron-validation-of-augmented-eicr-to-e2e-test-harness
Open

Extending schematron validation in e2e tests#568
robertandremitchell wants to merge 7 commits into
mainfrom
rob/434-add-schematron-validation-of-augmented-eicr-to-e2e-test-harness

Conversation

@robertandremitchell
Copy link
Copy Markdown
Collaborator

@robertandremitchell robertandremitchell commented May 20, 2026

Description

Enhances e2e tests to meet acceptance criteria from ticket:

  • E2E tests verify augmented eICR XML is well-formed
  • E2E tests verify augmented eICR contains expected elements
  • E2E tests verify augmented eICR retains all original content (no data loss)
  • Stretch: validate against actual Schematron rules if available

The bulk of the changed files are about bring validation logic into the augmentation-lambda. Is this something we want to do? I fell down this rabbit hole with the e2e tests because one of them was invalid. Based on the ticket, it sounds like APHL wants Mirth to do this? In which case, maybe we don't need/want this code in the augmentation-lambda as well?

The alternative is just to drop this sample7 data from the e2e and replace it with another test where we expect to go e2e, or write a separate e2e pathway for it where we expect the data to get kicked back.

Related Issues

Closes #434

Additional Notes

[Add any additional context or notes that reviewers should know about.]

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@robertandremitchell robertandremitchell linked an issue May 20, 2026 that may be closed by this pull request
4 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.89%. Comparing base (3a0500d) to head (755c7f6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   90.85%   90.89%   +0.03%     
==========================================
  Files          50       50              
  Lines        2691     2702      +11     
==========================================
+ Hits         2445     2456      +11     
  Misses        246      246              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Schematron validation of augmented eICR to E2E test harness

2 participants