feat!: Refactor TTC lambda function and condense saved models.#570
Draft
JNygaard-Skylight wants to merge 24 commits into
Draft
feat!: Refactor TTC lambda function and condense saved models.#570JNygaard-Skylight wants to merge 24 commits into
JNygaard-Skylight wants to merge 24 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 90.85% 90.43% -0.43%
==========================================
Files 50 50
Lines 2691 2666 -25
==========================================
- Hits 2445 2411 -34
- Misses 246 255 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ext-to-code into josh/ttc-lambda-refactor
…ext-to-code into josh/ttc-lambda-refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The primary goal of this branch was to remove fields from the models that are the outputs of our lambda functions (the metadata and the data that is passed from TTC to augmentation). This simplifies the code in several places and Pydantic handles the serialization/deserialization and allows us to improve the typing .
Details
_parse_nonstandard_codesfunction and all of its associated tests."schematron_error"from the nonstandard code model-
"eicr_metadata"field."schematron_error"test_augmentation_lambda_function.py:test_handler_success, andtest_handler_writes_outputs_to_s3as they were testing the same thing, but with different asserts.TTCMetadata._process_record_pipeline:Related Issues
Closes #527