fix: id exporter now generates static UIDs for struct and property nodes#528
Open
SoundMatt wants to merge 1 commit into
Open
fix: id exporter now generates static UIDs for struct and property nodes#528SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
The id exporter discarded the datatype tree returned by get_trees(), so struct (VSSDataStruct) and property (VSSDataProperty) nodes never received static UIDs. Capture the datatype tree and run export_node on it after processing the main signal tree. Resolves COVESA#439. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_trees()returns a(tree, datatype_tree)tuple. Theidexporter was discarding the second value, so struct (VSSDataStruct) and property (VSSDataProperty) nodes defined via--typesnever received static UIDs.One-line fix: capture
datatype_treeand runexport_nodeon it after processing the main tree.Resolves #439.
Test plan
uv run pytest tests/vspec/test_id_struct/passesvspec export id --types <types.vspec> -s <signals.vspec> -o out.yaml—out.yamlcontainsTypes.*entries withstaticUIDkeystests/vspec/test_static_uids/tests unaffected (no--typesused there)