New solver/optal cp#985
Open
OrestisLomis wants to merge 7 commits into
Open
Conversation
Collaborator
|
I think Ignace had a look at Optal before, so for him to check. Do remove the is_np_int and is_np_bool from the shared function and just use an inline check in your new file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw Optal was sponsoring JFPC and had a lot of similiraties to CPO, so I tried to add it to CPMpy (with the help of codex). Locally all tests pass, but I'm not sure how to actually add OptalCP to the CI for testing (both in general and with the license) so initially the PR will be a draft. Another tricky thing is that I'm not sure how to figure out whether someone has the preview version installed or the full/academic version. So I can not really throw a warning/error for that.. Instead the user will just get an error whenever the masked values are accessed.