Skip to content

Fix Chessground mouse hitbox desync after responsive layout shift #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tortue95 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Chessground mouse hitbox desync after responsive layout shift #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/components/Board/GameBoard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Chessground from '@react-chess/chessground'
import { BaseGame, GameNode, Color } from 'src/types'
import { MoveClassificationIcon } from 'src/components/Common/MoveIcons'
import type { DrawBrushes, DrawShape } from 'chessground/draw'
import { useCallback, useMemo, Dispatch, SetStateAction } from 'react'
import { useCallback, useEffect, useMemo, Dispatch, SetStateAction } from 'react'

interface MoveClassification {
blunder: boolean
Expand Down Expand Up @@ -71,6 +71,19 @@ export const GameBoard: React.FC<Props> = ({
const { playMoveSound } = useSound()
const boardInstanceKey = game?.id ?? 'board'

// After every position change, post-render layout shifts (stats panel,
// move list) can move the board without changing its size, leaving
// Chessground's cached bounds stale. Dispatching resize clears the cache
// so the next click re-measures from the correct DOM position.
// Chessground registers a permanent window.resize → bounds.clear() listener
// at init, so this is the correct low-impact way to invalidate it.
useEffect(() => {
const timeout = window.setTimeout(() => {
window.dispatchEvent(new Event('resize'))
}, 50)
return () => window.clearTimeout(timeout)
}, [currentNode])

const after = useCallback(
(from: string, to: string) => {
if (onPlayerMakeMove) onPlayerMakeMove([from, to])
Expand Down