feat: add Simplified Chinese localization#2008
Conversation
|
Too many files changed for review. ( Bypass the limit by tagging |
![tembo[bot]](https://avatars.githubusercontent.com/in/1223475?s=60&v=4){kind=small}
| reject( | ||
| new Error(chrome.runtime.lastError.message ?? "Failed to open tab"), | ||
| ); | ||
| reject(new Error(chrome.runtime.lastError.message ?? "打开标签页失败")); |
There was a problem hiding this comment.
These fallback error strings are now Chinese. If the extension isn’t actually locale-switched yet, this will surface Chinese for everyone and makes logs/debugging harder to search. Consider sourcing user-facing copy via chrome.i18n.getMessage(...) (with an English fallback) and keeping thrown/logged messages stable.
| url: OFFSCREEN_URL, | ||
| reasons: ["USER_MEDIA", "DISPLAY_MEDIA", "BLOBS", "AUDIO_PLAYBACK"], | ||
| justification: "Record and upload Cap videos from an extension page.", | ||
| justification: "从扩展页面录制并上传 Cap 视频。", |
There was a problem hiding this comment.
chrome.offscreen.createDocument’s justification can show up in review / debugging contexts; hardcoding one locale may be confusing. If you want this localized, pulling it from chrome.i18n keeps it consistent and lets you keep a safe English default.
| if (!panelFrame) throw new Error("panel frame missing"); | ||
| await panelFrame | ||
| .locator('button[aria-label="Close Cap and hide all recorder UI"]') | ||
| .locator('button[aria-label="关闭 Cap 并隐藏所有录制界面"]') |
There was a problem hiding this comment.
These e2e selectors are now coupled to translated aria-label copy. That tends to be brittle as soon as copy tweaks happen (or more locales get added). Consider adding a non-localized hook (e.g. data-testid or a stable id) to the close button and target that in tests instead.
| const panelFrame = frameWithUrl(targetPage, "popup.html"); | ||
| if (!panelFrame) throw new Error("panel frame missing"); | ||
| await expect(panelFrame.getByText("Recording failed.")).toBeVisible({ | ||
| await expect(panelFrame.getByText("录制失败。")).toBeVisible({ |
There was a problem hiding this comment.
Same idea here: asserting exact localized sentences (getByText("录制失败。")) makes the test fragile. If possible, assert on a stable error state/hook (test id, role + status attribute, or an error code) and keep the copy free to change per-locale.
1 participant
add Simplified Chinese localization