Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions api/cedar_metadata_records/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
from api.cedar_metadata_records.utils import can_create_record

from osf.exceptions import ValidationError
from osf.models import CedarMetadataRecord, CedarMetadataTemplate, Guid
from osf.models import CedarMetadataRecord, CedarMetadataTemplate, CollectionSubmission, Guid
from osf.utils.workflows import CollectionSubmissionStates

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -115,13 +116,32 @@ def create(self, validated_data):
raise PermissionDenied
if not template.is_active():
raise NotFound
record = CedarMetadataRecord(guid=guid, template=template, metadata=metadata, is_published=is_published)
try:
record.save()
except ValidationError as e:
raise InvalidModelValueError(detail=e.messages[0])
except IntegrityError:
raise JSONAPIException(detail=f'Cedar metadata record already exists: guid=[{guid._id}], template=[{template._id}]')
has_active_collection_submission = CollectionSubmission.objects.filter(
guid=guid,
collection__provider__required_metadata_template=template,
machine_state__in=[CollectionSubmissionStates.PENDING.value, CollectionSubmissionStates.ACCEPTED.value],
).exists()
if template.is_for_collections and not has_active_collection_submission:
record, _ = CedarMetadataRecord.objects.get_or_create(
guid=guid,
template=template,
defaults={'metadata': metadata, 'is_published': is_published},
)
if record.metadata != metadata or record.is_published != is_published:
record.metadata = metadata
record.is_published = is_published
try:
record.save()
except ValidationError as e:
raise InvalidModelValueError(detail=e.messages[0])
else:
record = CedarMetadataRecord(guid=guid, template=template, metadata=metadata, is_published=is_published)
try:
record.save()
except ValidationError as e:
raise InvalidModelValueError(detail=e.messages[0])
except IntegrityError:
raise JSONAPIException(detail=f'Cedar metadata record already exists: guid=[{guid._id}], template=[{template._id}]')
return record

def update(self, instance, validated_data):
Expand Down