Conversation
antonio2368
approved these changes
Apr 9, 2026
filimonov
reviewed
Apr 17, 2026
filimonov
reviewed
Apr 17, 2026
filimonov
reviewed
Apr 20, 2026
antonio2368
reviewed
May 5, 2026
| || !resp->get_accepted() | ||
| || resp->get_result_code() != cmd_result_code::OK; | ||
| if (non_ok) state->abandoned_.store(true); | ||
| size_t prev_in_flight = state->in_flight_.fetch_sub(1); |
Member
Author
There was a problem hiding this comment.
IIRC nuraft uses (void) instead of [[maybe_unused]], probably it targets an older C++ version that doesn't have it.
|
|
||
| void client_req_stream::append(std::vector< ptr<buffer> > logs) | ||
| { | ||
| ptr<req_msg> req = cs_new<req_msg>( |
Member
There was a problem hiding this comment.
if logs are empty do we need to call send?
I guess it should happen from the callers side but just in case?
Member
Author
There was a problem hiding this comment.
We don't call it with empty logs, so we're free to pick any reasonable behavior for this case here. Going through the normal code path seems good: it's less code and seems more likely to be useful to hypothetical imaginary future users (e.g. for some kind of heartbeats). Or do you mean it currently breaks because the server rejects such message or something?
antonio2368
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used by ClickHouse/ClickHouse#101757
Most of the code is from #104 by @filimonov