Skip to content

[client-v2] Fix Metrics test to be stable #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chernser merged 2 commits into from
Jun 26, 2026
+8 −1
Merged

[client-v2] Fix Metrics test to be stable #2900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
028c9af
added keep-alive < server 30 seconds to make test stable
chernser Jun 26, 2026
15951a3
jdbc-v2: updated keywords
chernser Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client-v2/src/test/java/com/clickhouse/client/metrics/MetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ public void testRegisterMetrics() throws Exception {
.serverSetting(ServerSettings.ASYNC_INSERT, "0")
.serverSetting(ServerSettings.WAIT_END_OF_QUERY, "1")
.registerClientMetrics(meterRegistry, "pool-test")
.setKeepAliveTimeout(10, ChronoUnit.SECONDS) // enforce connection cleanup
.build()) {

client.ping();
Expand All @@ -67,7 +68,11 @@ public void testRegisterMetrics() throws Exception {
Assert.assertEquals((int) leased.value(), 0);

Runnable task = () -> {
final long maxDelay = 15;
long t1 = System.currentTimeMillis();
try (QueryResponse response = client.query("SELECT 1").get()) {
long t = System.currentTimeMillis() - t1;
Assert.assertTrue(t < maxDelay, "Unexpected delay (t = " + t + ", but expected < " + maxDelay + " ms)");
Comment thread
chernser marked this conversation as resolved.
Assert.assertEquals((int) available.value(), 0);
Assert.assertEquals((int) leased.value(), 1);
} catch (Exception e) {
Expand Down
4 changes: 3 additions & 1 deletion jdbc-v2/src/main/java/com/clickhouse/jdbc/internal/parser/javacc/ClickHouseSqlUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ private static Set<String> initAllowedKeywordAliases() {
// Appended 05/27/2026
"CURSOR", "DETERMINISTIC", "ESCAPE", "SAMPLES", "STREAM", "UNKNOWN",
// Appended 06/10/2026
"IPV4_PREFIX_BITS", "IPV6_PREFIX_BITS", "TIMEZONE_HOUR", "TIMEZONE_MINUTE"
"IPV4_PREFIX_BITS", "IPV6_PREFIX_BITS", "TIMEZONE_HOUR", "TIMEZONE_MINUTE",
// Appended 06/26/2026
"ENUM", "HYPOTHETICAL", "WHATIF"
);
}

Expand Down
Loading