Disable subtotal line in groups#267
Closed
eagleoriginal wants to merge 2 commits into
Closed
Conversation
Correct Break Right Groups according on left groups Ends without Subtotal lines # Conflicts: # tests/Gauges/GroupTagTests_DisableSubTotals_MergeLabels.xlsx # tests/Templates/GroupTagTests_DisableSubTotals_MergeLabels.xlsx
Member
|
Thanks for your contribution. I will review this PR shortly. |
Member
|
@eagleoriginal I understand this was a long ago but could you please upgrade your PR to the latest version of |
Author
|
Ok. I will see what I can do. But not now, I will do it next month.
ср, 26 июл. 2023 г. в 15:52, Aleksei ***@***.***>:
… @eagleoriginal <https://github.com/eagleoriginal> I understand this was a
long ago but could you please upgrade your PR to the latest version of
develop branch if it the feature request is still relevant?
—
Reply to this email directly, view it on GitHub
<#267 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEL2KR5FTUWYPERSXQRGJLDXSEHHXANCNFSM5RZALQWA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
С уважением Орлов Игорь.
|
Author
|
Hello. |
Author
|
This is outedated thread. So Close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propose new feature. Subtotal Line totally removed if only merging needing.
This achieve by using tag DisableSubtotalLine. Like
<<Group MergeLabels=Merge2 DisableSubtotalLine>>Sometimes it can be useful, when users ask for groups in secondary columns(it can be date, or some entity), but subtotals usually needs only in first column(usually organization).
result you can see in file
GroupTagTests_DisableSubTotals_MergeLabels.xlsx
Also fix bug of style of merged cell(sometimes merged cells become gray).
Because in row on right column placed subtotal footer.
After that some tests have broken with error
for example ClosedXML.Report.Tests.GroupTagTests.Customers
TestCase
InlineData("GroupTagTests_DisableOutline.xlsx")Expected True because Cell style are not equal starting from B6, but found False.I dont know much ClosedXml.Reports but there are something wrong in line:
int cellIdx = _maxLevel - subGroup.Level + 1;