Skip to content

Added command to display contents of stdderr file#255

Open
jayaike wants to merge 20 commits into
Cloud-CV:masterfrom
jayaike:echo-stderr-file
Open

Added command to display contents of stdderr file#255
jayaike wants to merge 20 commits into
Cloud-CV:masterfrom
jayaike:echo-stderr-file

Conversation

@jayaike

@jayaike jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor

I have added a command to display the contents of the stderr file

It is invoked by running evalai submission SUBMISSION_ID stderr

@krtkvrm krtkvrm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests

@jayaike

jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

@vkartik97 Alright

@jayaike

jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

See screenshot
Screenshot (127)

@jayaike

jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

I also made all the responses into variables so changing them won't be ann issue :) @vkartik97 @Ram81 @RishabhJain2018

@pushkalkatara

Copy link
Copy Markdown

@nsjcorps Still the code coverage is decreased. Can you resolve it?

@jayaike

jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

I mentioned the reason why the code coverage is down @pushkalkatara

@jayaike

jayaike commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

There is a part of the function that I can not test because it never gets called which I showed above. That would be the exception raised for the MissingSchema @pushkalkatara

@jayaike

jayaike commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

If the exception was raised in the request block of code it would be called. However, it is not raised there @pushkalkatara

@jayaike

jayaike commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

Should I put it there so you can see?

Comment thread evalai/utils/submissions.py Outdated
Comment on lines +301 to +308
except requests.exceptions.MissingSchema:
echo(
style(
"\nThe Submission is yet to be evaluated.\n",
bold=True,
fg="yellow",
)
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why have you used requests.exceptions.MissingSchema.
Going by docs,MissingSchema is for The URL schema (e.g. http or https) is missing. exception.

@jayaike

jayaike commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

What should I use @vkartik97 ? I took it from the display submission result function. Kindly let me know your comments

@krtkvrm

krtkvrm commented Jan 13, 2020

Copy link
Copy Markdown
Member

The Aim here is to find which condition is applicable for:

The Submission is yet to be evaluated.

How about you check the status of submission data? How about status?

@jayaike

jayaike commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

Workin on It now @vkartik97

@jayaike

jayaike commented Jan 13, 2020

Copy link
Copy Markdown
Contributor Author

Done @pushkalkatara @vkartik97

Comment thread evalai/utils/submissions.py
Comment thread evalai/utils/submissions.py Outdated
Comment thread evalai/utils/submissions.py Outdated
@jayaike

jayaike commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

Done!!

@krtkvrm krtkvrm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@jayaike

jayaike commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @vkartik97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants