Fix: parsing ambiguity in cib_ops_path format handling#315
Open
aleksei-burlakov wants to merge 1 commit into
Open
Fix: parsing ambiguity in cib_ops_path format handling#315aleksei-burlakov wants to merge 1 commit into
aleksei-burlakov wants to merge 1 commit into
Conversation
The CibController#ops action expects the :id parameter in the form <resource>,<node>. When Rails appends .json to the URL, resource or node names containing dots become ambiguous and require special route constraints. The CibController#ops function expects and :id in the form <resource>,<node> but there comes a concatenation of 3 values <resource>,<node><format>. Commit 32c1471 enables correct parsing 3 values, but it breaks the parsing in other controllers, when there is no <format> given. One could possibly distinguish the regular expressions for each of the cases, but let's better not glue too many values together, and just move the :format out, as a separate argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CibController#ops action expects the :id parameter in the form ,. When Rails appends .json to the URL, resource or node names containing dots become ambiguous and require special route constraints.
The CibController#ops function expects and :id in the form , but there comes a concatenation of 3 values ,. Commit 32c1471 enables correct parsing 3 values, but it breaks the parsing in other controllers, when there is no given. One could possibly distinguish the regular expressions for each of the cases, but let's better not glue too many values together, and just move the :format out, as a separate argument.