Skip to content

fix: use stable PR route for webview links - #75

Open
ivanmilevtues wants to merge 1 commit into
mainfrom
fix/stable-webview-pr-route
Open

fix: use stable PR route for webview links#75
ivanmilevtues wants to merge 1 commit into
mainfrom
fix/stable-webview-pr-route

Conversation

@ivanmilevtues

Copy link
Copy Markdown
Member

Summary

  • generate hosted webview links as the stable GitHub-compatible /{owner}/{repo}/pull/{pr} route
  • remove workflow run IDs from the CTA link-building path while preserving run metadata in uploaded artifacts
  • update user-facing input documentation and URL tests for the stable route

Tests

  • python -m unittest tests.test_build_cta -v
  • python -m unittest discover -s tests -p 'test_*.py' (181 tests)
  • pre-commit run --all-files
  • git diff --check
  • CLI smoke test confirming https://app.codeboarding.org/Org/Repo/pull/9

@codeboarding-review

codeboarding-review Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Architecture review · no architectural changes

graph LR
    n_Analysis_Engine_Adapter["Analysis Engine Adapter"]
    n_Visual_Rendering_Engine["Visual Rendering Engine"]
    n_Structural_Diff_Engine["Structural Diff Engine"]
    n_Telemetry_Feedback_Handler["Telemetry #38; Feedback Handler"]
    n_Interaction_Orchestrator["Interaction Orchestrator"]
    n_Analysis_Engine_Adapter -- "Passes repository context for CTA generation" --> n_Interaction_Orchestrator
    n_Visual_Rendering_Engine -- "Queries for architectural changes" --> n_Structural_Diff_Engine
    n_Structural_Diff_Engine -- "Provides change-set data" --> n_Visual_Rendering_Engine
    n_Interaction_Orchestrator -- "Consumes issue counts for UI" --> n_Visual_Rendering_Engine
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
Loading

Colors indicate component changes compared to target branch main: 🟩 Added · 🟨 Modified · 🟥 Removed

Download the PR analysis artifacts from this workflow artifact.


⚠️ 1 architecture issue found — open CodeBoarding to explore them.

Explore this PR’s architecture in your browser or VS Code.

codeboarding-action · run

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec3dc33058

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread action.yml
Comment on lines 1324 to 1325
HEAD_ANALYSIS: ${{ steps.analyze.outputs.head_analysis }}
RUN_ID: ${{ github.run_id }}
CHANGED_COUNT: ${{ steps.diagram.outputs.n_changed }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the run ID used by the comment footer

For every review-mode run, removing RUN_ID from this step's environment leaves the existing interpolation at action.yml:1413 unset. Because this script does not enable set -u, the step succeeds but every posted comment ends with codeboarding-action · run instead of the identifying GitHub run number; keep github.run_id available here even though the webview URL no longer needs it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants