Fixes #211 replace fixed height with min-height on timetable wrapper#215
Open
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
Open
Fixes #211 replace fixed height with min-height on timetable wrapper#215sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
sidharth-vijayan wants to merge 1 commit intoCodeChefVIT:prodfrom
Conversation
atharvaSharma17
requested changes
May 4, 2026
Collaborator
atharvaSharma17
left a comment
atharvaSharma17
left a comment
There was a problem hiding this comment.
Don’t just squish the grid to make it fit. This change is distorting the layout. Please adjust the surrounding containers and sibling components so the timetable grid can maintain its intended aspect ratio and spacing. The layout should adapt holistically rather than compressing the grid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The timetable grid on the Slot View page was being cut off and
required scrolling to see fully.
Root Cause
The wrapper div had a fixed
h-[480px]Tailwind class, whichhard-capped the height of the TimeTable component, clipping
any content beyond 480px.
Fix
Changed
h-[480px]tomin-h-[480px]inslot-view.tsx.This allows the container to grow naturally with its content
while still having a sensible minimum height.
Closes #211